RE: [PATCH V2] x86: Enable separate shrink wrapping

2025-06-13 Thread Cui, Lili
> -Original Message- > From: Uros Bizjak > Sent: Thursday, June 12, 2025 5:05 PM > To: Cui, Lili > Cc: gcc-patches@gcc.gnu.org; Liu, Hongtao ; > richard.guent...@gmail.com; Michael Matz > Subject: Re: [PATCH V2] x86: Enable separate shrink wrapping > >

Re: [PATCH V2] x86: Enable separate shrink wrapping

2025-06-12 Thread Uros Bizjak
On Thu, Jun 12, 2025 at 10:58 AM Uros Bizjak wrote: > > On Thu, Jun 12, 2025 at 9:26 AM Cui, Lili wrote: > > > > > > @@ -7753,8 +7762,12 @@ pro_epilogue_adjust_stack (rtx dest, rtx src, > > > > rtx > > > offset, > > > > add_frame_related_expr = true; > > > > } > > > > > > > > + if (

Re: [PATCH V2] x86: Enable separate shrink wrapping

2025-06-12 Thread Uros Bizjak
On Thu, Jun 12, 2025 at 9:26 AM Cui, Lili wrote: > > > > @@ -7753,8 +7762,12 @@ pro_epilogue_adjust_stack (rtx dest, rtx src, > > > rtx > > offset, > > > add_frame_related_expr = true; > > > } > > > > > > + if (crtl->shrink_wrapped_separate) insn = emit_insn (gen_rtx_SET > > > + (d

RE: [PATCH V2] x86: Enable separate shrink wrapping

2025-06-12 Thread Cui, Lili
> > @@ -7753,8 +7762,12 @@ pro_epilogue_adjust_stack (rtx dest, rtx src, > > rtx > offset, > > add_frame_related_expr = true; > > } > > > > + if (crtl->shrink_wrapped_separate) insn = emit_insn (gen_rtx_SET > > + (dest, gen_rtx_PLUS (Pmode, src, addend))); > > Please use ix86_expa

RE: [PATCH V2] x86: Enable separate shrink wrapping

2025-06-11 Thread Cui, Lili
> > From: Lili Cui > > > > Hi Uros, > > > > Thank you very much for providing detailed BKM to reproduce Linux kernel > > boot > failure. My patch and Matz's patch have this problem. We inserted a SUB > between > TEST and JLE, and the SUB changes the value of EFlags. The branch JLE here > went

Re: [PATCH V2] x86: Enable separate shrink wrapping

2025-06-11 Thread Uros Bizjak
On Wed, Jun 11, 2025 at 5:33 AM Cui, Lili wrote: > > From: Lili Cui > > Hi Uros, > > Thank you very much for providing detailed BKM to reproduce Linux kernel boot > failure. My patch and Matz's patch have this problem. We inserted a SUB > between TEST and JLE, and the SUB changes the value of