Re: [PATCH AArch64/V3]Add new patterns for vcond_mask and vec_cmp

2017-06-27 Thread Andrew Pinski
On Mon, Aug 1, 2016 at 6:18 AM, Bin Cheng wrote: > Hi, > This is the 3rd version patch implementing vcond_mask and vec_cmp patterns on > AArch64. > Bootstrap and test along with next patch on AArch64, is it OK? > > Thanks, > bin > > 2016-07-28 Alan Lawrence > Renlin Li >

Re: [PATCH AArch64/V3]Add new patterns for vcond_mask and vec_cmp

2016-08-11 Thread Bin.Cheng
On Thu, Aug 11, 2016 at 9:36 AM, Bin.Cheng wrote: > On Thu, Aug 11, 2016 at 8:08 AM, Andreas Schwab wrote: >> ../../gcc/config/aarch64/aarch64-simd.md: In function 'rtx_def* >> gen_vec_cmpv2sfv2si(rtx, rtx, rtx, rtx)': >> ../../gcc/config/aarch64/aarch64-simd.md:2498:17: error: 'comparison' may

Re: [PATCH AArch64/V3]Add new patterns for vcond_mask and vec_cmp

2016-08-11 Thread Bin.Cheng
On Thu, Aug 11, 2016 at 8:08 AM, Andreas Schwab wrote: > ../../gcc/config/aarch64/aarch64-simd.md: In function 'rtx_def* > gen_vec_cmpv2sfv2si(rtx, rtx, rtx, rtx)': > ../../gcc/config/aarch64/aarch64-simd.md:2498:17: error: 'comparison' may be > used uninitialized in this function [-Werror=maybe

Re: [PATCH AArch64/V3]Add new patterns for vcond_mask and vec_cmp

2016-08-11 Thread Andreas Schwab
../../gcc/config/aarch64/aarch64-simd.md: In function 'rtx_def* gen_vec_cmpv2sfv2si(rtx, rtx, rtx, rtx)': ../../gcc/config/aarch64/aarch64-simd.md:2498:17: error: 'comparison' may be used uninitialized in this function [-Werror=maybe-uninitialized] emit_insn (comparison (operands[0], opera

Re: [PATCH AArch64/V3]Add new patterns for vcond_mask and vec_cmp

2016-08-09 Thread James Greenhalgh
On Mon, Aug 08, 2016 at 12:10:00PM +0100, Bin.Cheng wrote: > On Mon, Aug 8, 2016 at 11:40 AM, James Greenhalgh > wrote: > > On Mon, Aug 01, 2016 at 01:18:53PM +, Bin Cheng wrote: > >> Hi, > >> This is the 3rd version patch implementing vcond_mask and vec_cmp patterns > >> on > >> AArch64. Bo

Re: [PATCH AArch64/V3]Add new patterns for vcond_mask and vec_cmp

2016-08-08 Thread Bin.Cheng
On Mon, Aug 8, 2016 at 11:40 AM, James Greenhalgh wrote: > On Mon, Aug 01, 2016 at 01:18:53PM +, Bin Cheng wrote: >> Hi, >> This is the 3rd version patch implementing vcond_mask and vec_cmp patterns on >> AArch64. Bootstrap and test along with next patch on AArch64, is it OK? > > OK, with a c

Re: [PATCH AArch64/V3]Add new patterns for vcond_mask and vec_cmp

2016-08-08 Thread James Greenhalgh
On Mon, Aug 01, 2016 at 01:18:53PM +, Bin Cheng wrote: > Hi, > This is the 3rd version patch implementing vcond_mask and vec_cmp patterns on > AArch64. Bootstrap and test along with next patch on AArch64, is it OK? OK, with a couple of comments below, one on an extension and once style nit.