Re: [PATCH 7/X] libsanitizer: Add tests

2020-11-23 Thread Richard Sandiford via Gcc-patches
Matthew Malcomson writes: > new file mode 100644 > index > ..a6a11866823ae8ba9c20b79ac068e84aa73e053d > --- /dev/null > +++ b/gcc/testsuite/lib/hwasan-dg.exp > @@ -0,0 +1,121 @@ > +# Copyright (C) 2012-2019 Free Software Foundation, Inc. 2012-2020 > + > +

Re: [PATCH 7/X] libsanitizer: Add tests

2020-11-23 Thread Matthew Malcomson via Gcc-patches
Hello, Update of the hwasan tests attached. Ok for trunk? (NOTE on the state of the entire patch series: Currently re-testing everything from scratch to ensure I didn't get tripped up from old state carried around. Also looking into PR 97941 on hwasan. As yet don't understand what's goin

Re: [PATCH 7/X] libsanitizer: Add tests

2020-11-20 Thread Richard Sandiford via Gcc-patches
Matthew Malcomson writes: > Adding hwasan tests. > > Only interesting thing here is that we have to make sure the tagging mechanism > is deterministic to avoid flaky tests. Sorry for not reviewing this one earlier. TBH I only spot-checked the tests themselves (they look good). But on hwasan-dg.

Re: [PATCH 7/X] [libsanitizer] Add tests

2019-12-16 Thread Matthew Malcomson
I just remembered that the run tests all fail on cross builds. This patch includes the effective target check to determine whether a hwasan binary can be run on a given target. We then add that target requirement to all tests which need to run. Adding hwasan tests. Only interesting thing here

Re: [PATCH 7/X] [libsanitizer] Add tests

2019-11-20 Thread Martin Liška
On 11/7/19 7:37 PM, Matthew Malcomson wrote: Adding hwasan tests. Frankly, these could be tidied up a little. I will be tidying them up while getting feedback on the hwasan introduction. Which is file, however I would consider adding some dynamic allocation tests. One can easily inspire either