Re: [PATCH 6/X] libsanitizer: Add hwasan pass and associated gimple changes

2020-10-14 Thread Richard Sandiford via Gcc-patches
Matthew Malcomson writes: > @@ -133,6 +137,13 @@ enum asan_mark_flags > #undef DEF > }; > > +enum hwasan_mark_flags > +{ > +#define DEF(X) HWASAN_MARK_##X > + IFN_ASAN_MARK_FLAGS > +#undef DEF > +}; Are these used anywhere? It looks like expand_HWASAN_MARK uses the plain asan versions. > @

Re: [PATCH 6/X] [libsanitizer] Add hwasan pass and associated gimple changes

2020-01-13 Thread Matthew Malcomson
> On 12/12/19 4:19 PM, Matthew Malcomson wrote: >> - if (is_store && !param_asan_instrument_writes) >> + if (is_store >> + && (!param_asan_instrument_writes || !param_hwasan_instrument_writes)) >> return; >> - if (!is_store && !param_asan_instrument_reads) >> + if (!is_store >> + && (!param_asan_in

Re: [PATCH 6/X] [libsanitizer] Add hwasan pass and associated gimple changes

2020-01-07 Thread Martin Liška
On 12/12/19 4:19 PM, Matthew Malcomson wrote: - if (is_store && !param_asan_instrument_writes) + if (is_store + && (!param_asan_instrument_writes || !param_hwasan_instrument_writes)) return; - if (!is_store && !param_asan_instrument_reads) + if (!is_store + && (!param_asan_instrument_reads || !pa

Re: [PATCH 6/X] [libsanitizer] Add hwasan pass and associated gimple changes

2019-11-20 Thread Martin Liška
On 11/7/19 7:37 PM, Matthew Malcomson wrote: There are four main features to this change: 1) Check pointer tags match address tags. In the new `hwasan` pass we put HWASAN_CHECK internal functions around all memory accesses, to check that tags in the pointer being used match the tag stored in sh