Re: [PATCH 6/7] Kill pedantic warnings on system headers macros

2011-09-18 Thread Dodji Seketeli
Jason Merrill writes: > On 09/16/2011 04:46 AM, Dodji Seketeli wrote: >> struct c_declspecs * >> -finish_declspecs (struct c_declspecs *specs) >> +finish_declspecs (struct c_declspecs *specs, >> + location_t where) > > Let's call this first_token_loc, too. And mention it in the

Re: [PATCH 6/7] Kill pedantic warnings on system headers macros

2011-09-17 Thread Jason Merrill
On 09/16/2011 04:46 AM, Dodji Seketeli wrote: struct c_declspecs * -finish_declspecs (struct c_declspecs *specs) +finish_declspecs (struct c_declspecs *specs, + location_t where) Let's call this first_token_loc, too. And mention it in the function comment. OK with that chan

Re: [PATCH 6/7] Kill pedantic warnings on system headers macros

2011-09-16 Thread Dodji Seketeli
Jason Merrill writes: > On 07/16/2011 10:37 AM, Dodji Seketeli wrote: > > + location_t here = c_parser_peek_token (parser)->location; > > Perhaps "first_token_loc"? OK, changed. > > > + SYNTAX_ERROR2_AT (prev_virtual_location, > > + "missing binary opera

Re: [PATCH 6/7] Kill pedantic warnings on system headers macros

2011-09-12 Thread Jason Merrill
On 07/16/2011 10:37 AM, Dodji Seketeli wrote: + location_t here = c_parser_peek_token (parser)->location; Perhaps "first_token_loc"? It's unfortunate that we don't retain the locations of the individual declspecs, but I don't expect you to fix that. + SYNTAX_ERROR2_AT (prev_virt