Re: [PATCH 6/6] Add manual GTY hooks

2013-09-05 Thread Diego Novillo
On Wed, Sep 4, 2013 at 11:40 AM, David Malcolm wrote: > On Sat, 2013-08-31 at 19:27 +0200, Richard Biener wrote: >> David Malcolm wrote: >> >On Fri, 2013-08-30 at 10:09 +0200, Richard Biener wrote: >> >> On Thu, Aug 29, 2013 at 9:44 PM, Steven Bosscher >> > wrote: >> >> > On Thu, Aug 29, 2013 at

Re: [PATCH 6/6] Add manual GTY hooks

2013-09-05 Thread Richard Biener
On Wed, Sep 4, 2013 at 5:40 PM, David Malcolm wrote: > On Sat, 2013-08-31 at 19:27 +0200, Richard Biener wrote: >> David Malcolm wrote: >> >On Fri, 2013-08-30 at 10:09 +0200, Richard Biener wrote: >> >> On Thu, Aug 29, 2013 at 9:44 PM, Steven Bosscher >> > wrote: >> >> > On Thu, Aug 29, 2013 at 6

Re: [PATCH 6/6] Add manual GTY hooks

2013-09-04 Thread David Malcolm
On Sat, 2013-08-31 at 19:27 +0200, Richard Biener wrote: > David Malcolm wrote: > >On Fri, 2013-08-30 at 10:09 +0200, Richard Biener wrote: > >> On Thu, Aug 29, 2013 at 9:44 PM, Steven Bosscher > > wrote: > >> > On Thu, Aug 29, 2013 at 6:20 PM, David Malcolm > > wrote: > >> >> * gimple.c (

Re: [PATCH 6/6] Add manual GTY hooks

2013-08-31 Thread Richard Biener
David Malcolm wrote: >On Fri, 2013-08-30 at 10:09 +0200, Richard Biener wrote: >> On Thu, Aug 29, 2013 at 9:44 PM, Steven Bosscher > wrote: >> > On Thu, Aug 29, 2013 at 6:20 PM, David Malcolm > wrote: >> >> * gimple.c (gt_ggc_mx (gimple)): New, as required by >GTY((user)). >> >> (g

Re: [PATCH 6/6] Add manual GTY hooks

2013-08-31 Thread David Malcolm
On Fri, 2013-08-30 at 10:09 +0200, Richard Biener wrote: > On Thu, Aug 29, 2013 at 9:44 PM, Steven Bosscher > wrote: > > On Thu, Aug 29, 2013 at 6:20 PM, David Malcolm wrote: > >> * gimple.c (gt_ggc_mx (gimple)): New, as required by GTY((user)). > >> (gt_pch_nx (gimple)): Likewis

Re: [PATCH 6/6] Add manual GTY hooks

2013-08-30 Thread David Malcolm
On Fri, 2013-08-30 at 10:40 +0200, Richard Biener wrote: > On Thu, Aug 29, 2013 at 6:20 PM, David Malcolm wrote: > > * gimple.c (gt_ggc_mx (gimple)): New, as required by GTY((user)). > > (gt_pch_nx (gimple)): Likewise. > > (gt_pch_nx (gimple, gt_pointer_operator, void *)):

Re: [PATCH 6/6] Add manual GTY hooks

2013-08-30 Thread Richard Biener
On Thu, Aug 29, 2013 at 6:20 PM, David Malcolm wrote: > * gimple.c (gt_ggc_mx (gimple)): New, as required by GTY((user)). > (gt_pch_nx (gimple)): Likewise. > (gt_pch_nx (gimple, gt_pointer_operator, void *)): Likewise. > * gimple.h (gt_ggc_mx (gimple)): Declare. >

Re: [PATCH 6/6] Add manual GTY hooks

2013-08-30 Thread Richard Biener
On Thu, Aug 29, 2013 at 9:44 PM, Steven Bosscher wrote: > On Thu, Aug 29, 2013 at 6:20 PM, David Malcolm wrote: >> * gimple.c (gt_ggc_mx (gimple)): New, as required by GTY((user)). >> (gt_pch_nx (gimple)): Likewise. > > GIMPLE isn't supposed to end up in a PCH. Can you please make

Re: [PATCH 6/6] Add manual GTY hooks

2013-08-30 Thread Richard Biener
On Thu, Aug 29, 2013 at 6:20 PM, David Malcolm wrote: > * gimple.c (gt_ggc_mx (gimple)): New, as required by GTY((user)). > (gt_pch_nx (gimple)): Likewise. > (gt_pch_nx (gimple, gt_pointer_operator, void *)): Likewise. > * gimple.h (gt_ggc_mx (gimple)): Declare. >

Re: [PATCH 6/6] Add manual GTY hooks

2013-08-29 Thread Steven Bosscher
On Thu, Aug 29, 2013 at 6:20 PM, David Malcolm wrote: > * gimple.c (gt_ggc_mx (gimple)): New, as required by GTY((user)). > (gt_pch_nx (gimple)): Likewise. GIMPLE isn't supposed to end up in a PCH. Can you please make this function simply call gcc_unreachable()? FWIW 1: I really