Re: [PATCH 5/7 v6] vect: Support vector load/store with length in vectorizer

2020-07-10 Thread Kewen.Lin via Gcc-patches
Hi Richard, on 2020/7/8 下午8:50, Richard Sandiford wrote: > "Kewen.Lin" writes: >>> […] I tested the updated patch with this releasing, LOOP_VINFO_PEELING_FOR_GAPS part looks fine, but LOOP_VINFO_PEELING_FOR_ALIGNMENT caused one case to fail at execution during vect-partial-vector-u

Re: [PATCH 5/7 v6] vect: Support vector load/store with length in vectorizer

2020-07-08 Thread Richard Sandiford
"Kewen.Lin" writes: >> […] >>> I tested the updated patch with this releasing, LOOP_VINFO_PEELING_FOR_GAPS >>> part looks fine, but LOOP_VINFO_PEELING_FOR_ALIGNMENT caused one case to >>> fail at execution during vect-partial-vector-usage=2. So far the patch >>> doesn't handle any niters_skip cas

Re: [PATCH 5/7 v6] vect: Support vector load/store with length in vectorizer

2020-07-08 Thread Kewen.Lin via Gcc-patches
Hi Richard, on 2020/7/7 下午6:15, Richard Sandiford wrote: > "Kewen.Lin" writes: >> Hi Richard, >> >> on 2020/7/1 下午11:17, Richard Sandiford wrote: >>> "Kewen.Lin" writes: on 2020/7/1 上午3:53, Richard Sandiford wrote: > "Kewen.Lin" writes: Sorry, I didn't quite follow this comme

Re: [PATCH 5/7 v6] vect: Support vector load/store with length in vectorizer

2020-07-07 Thread Kewen.Lin via Gcc-patches
Hi Richard, on 2020/7/7 下午6:44, Richard Sandiford wrote: > "Kewen.Lin" writes: >> on 2020/7/2 下午1:20, Kewen.Lin via Gcc-patches wrote: >>> on 2020/7/1 下午11:17, Richard Sandiford wrote: "Kewen.Lin" writes: > on 2020/7/1 上午3:53, Richard Sandiford wrote: >> "Kewen.Lin" writes: >>>

Re: [PATCH 5/7 v6] vect: Support vector load/store with length in vectorizer

2020-07-07 Thread Richard Sandiford
"Kewen.Lin" writes: > on 2020/7/2 下午1:20, Kewen.Lin via Gcc-patches wrote: >> on 2020/7/1 下午11:17, Richard Sandiford wrote: >>> "Kewen.Lin" writes: on 2020/7/1 上午3:53, Richard Sandiford wrote: > "Kewen.Lin" writes: >> + /* Decide whether to use fully-masked approach. */ >>

Re: [PATCH 5/7 v6] vect: Support vector load/store with length in vectorizer

2020-07-07 Thread Richard Sandiford
"Kewen.Lin" writes: > Hi Richard, > > on 2020/7/1 下午11:17, Richard Sandiford wrote: >> "Kewen.Lin" writes: >>> on 2020/7/1 上午3:53, Richard Sandiford wrote: "Kewen.Lin" writes: >poly_uint64 vf = LOOP_VINFO_VECT_FACTOR (loop_vinfo); > + tree length_limit = NULL_TREE; > + /*

Re: [PATCH 5/7 v6] vect: Support vector load/store with length in vectorizer

2020-07-07 Thread Kewen.Lin via Gcc-patches
Hi Richard, on 2020/7/2 下午1:20, Kewen.Lin via Gcc-patches wrote: > on 2020/7/1 下午11:17, Richard Sandiford wrote: >> "Kewen.Lin" writes: >>> on 2020/7/1 上午3:53, Richard Sandiford wrote: "Kewen.Lin" writes: [...] >> Hmm, OK. But in that case can you update the names of the variables >> to ma

Re: [PATCH 5/7 v6] vect: Support vector load/store with length in vectorizer

2020-07-01 Thread Kewen.Lin via Gcc-patches
Hi Richard, on 2020/7/1 下午11:17, Richard Sandiford wrote: > "Kewen.Lin" writes: >> on 2020/7/1 上午3:53, Richard Sandiford wrote: >>> "Kewen.Lin" writes: poly_uint64 vf = LOOP_VINFO_VECT_FACTOR (loop_vinfo); + tree length_limit = NULL_TREE; + /* For length, we need length_limit

Re: [PATCH 5/7 v6] vect: Support vector load/store with length in vectorizer

2020-07-01 Thread Richard Sandiford
"Kewen.Lin" writes: > on 2020/7/1 上午3:53, Richard Sandiford wrote: >> "Kewen.Lin" writes: >>>poly_uint64 vf = LOOP_VINFO_VECT_FACTOR (loop_vinfo); >>> + tree length_limit = NULL_TREE; >>> + /* For length, we need length_limit to check length in range. */ >>> + if (!vect_for_masking) >>> +

Re: [PATCH 5/7 v6] vect: Support vector load/store with length in vectorizer

2020-07-01 Thread Kewen.Lin via Gcc-patches
Hi Richard, Many thanks for your great review comments! on 2020/7/1 上午3:53, Richard Sandiford wrote: > "Kewen.Lin" writes: >> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi >> index 06a04e3d7dd..284c15705ea 100644 >> --- a/gcc/doc/invoke.texi >> +++ b/gcc/doc/invoke.texi >> @@ -13389,6 +

Re: [PATCH 5/7 v6] vect: Support vector load/store with length in vectorizer

2020-06-30 Thread Richard Sandiford
"Kewen.Lin" writes: > diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi > index 06a04e3d7dd..284c15705ea 100644 > --- a/gcc/doc/invoke.texi > +++ b/gcc/doc/invoke.texi > @@ -13389,6 +13389,13 @@ by the copy loop headers pass. > @item vect-epilogues-nomask > Enable loop epilogue vectorizatio