Re: [PATCH 5/7] Add line map statistics to -fmem-report output

2011-09-20 Thread Jason Merrill
OK. Jason

Re: [PATCH 5/7] Add line map statistics to -fmem-report output

2011-09-20 Thread Dodji Seketeli
Jason Merrill writes: > It's hard to compare macro_maps_allocated_size with > macro_maps_used_size since you have to do subtraction to discover both > values from what is printed. OK, I have changed the statistics components accordingly. > And do the addition in dump_line_table_statistics rath

Re: [PATCH 5/7] Add line map statistics to -fmem-report output

2011-09-17 Thread Jason Merrill
On 09/16/2011 04:13 AM, Dodji Seketeli wrote: It seems odd to add in the locations size here since it's also printed separately. I wanted macro_maps_used_size to really reflect the total used size for macro maps, without having to mentally do the addition of its two components. But at the same

Re: [PATCH 5/7] Add line map statistics to -fmem-report output

2011-09-16 Thread Dodji Seketeli
> On 07/16/2011 10:37 AM, Dodji Seketeli wrote: > > +#define ONE_M ONE_K * ONE_K > > Parenthesize this so that users don't need to. OK. > > > + macro_maps_used_size = > > +LINEMAPS_MACRO_USED (set) * sizeof (struct line_map) > > ++ macro_maps_locations_size; > > It seems odd to add in

Re: [PATCH 5/7] Add line map statistics to -fmem-report output

2011-09-12 Thread Jason Merrill
On 07/16/2011 10:37 AM, Dodji Seketeli wrote: +#define ONE_M ONE_K * ONE_K Parenthesize this so that users don't need to. + macro_maps_used_size = +LINEMAPS_MACRO_USED (set) * sizeof (struct line_map) ++ macro_maps_locations_size; It seems odd to add in the locations size here sinc