Re: [PATCH 5/5] Formatted printing for dump_* in the middle-end

2018-07-31 Thread Joseph Myers
On Tue, 31 Jul 2018, David Malcolm wrote: > I didn't exhaustively check every callsite to the changed calls; I'm > assuming that -Wformat during bootstrap has effectively checked that > for me. Though now I think about it, I note that we use > HOST_WIDE_INT_PRINT_DEC in many places: is this guara

Re: [PATCH 5/5] Formatted printing for dump_* in the middle-end

2018-07-31 Thread Richard Biener
On Tue, Jul 31, 2018 at 4:21 PM Richard Biener wrote: > > On Tue, Jul 31, 2018 at 4:19 PM David Malcolm wrote: > > > > On Tue, 2018-07-31 at 15:03 +0200, Richard Biener wrote: > > > On Fri, Jul 27, 2018 at 11:49 PM David Malcolm > > > wrote: > > > > > > > > This patch converts dump_print and dum

Re: [PATCH 5/5] Formatted printing for dump_* in the middle-end

2018-07-31 Thread Richard Biener
On Tue, Jul 31, 2018 at 4:19 PM David Malcolm wrote: > > On Tue, 2018-07-31 at 15:03 +0200, Richard Biener wrote: > > On Fri, Jul 27, 2018 at 11:49 PM David Malcolm > > wrote: > > > > > > This patch converts dump_print and dump_printf_loc from using > > > printf (and thus ATTRIBUTE_PRINTF) to usi

Re: [PATCH 5/5] Formatted printing for dump_* in the middle-end

2018-07-31 Thread David Malcolm
On Tue, 2018-07-31 at 15:03 +0200, Richard Biener wrote: > On Fri, Jul 27, 2018 at 11:49 PM David Malcolm > wrote: > > > > This patch converts dump_print and dump_printf_loc from using > > printf (and thus ATTRIBUTE_PRINTF) to using a new pretty-printer > > based on pp_format, which supports form

Re: [PATCH 5/5] Formatted printing for dump_* in the middle-end

2018-07-31 Thread Richard Biener
On Fri, Jul 27, 2018 at 11:49 PM David Malcolm wrote: > > This patch converts dump_print and dump_printf_loc from using > printf (and thus ATTRIBUTE_PRINTF) to using a new pretty-printer > based on pp_format, which supports formatting middle-end types. > > In particular, the following codes are im