Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

2019-05-20 Thread Martin Sebor
On 5/20/19 2:00 PM, Joseph Myers wrote: Another couple of issues in the change as committed: + GCC_BAD ("%, ignored"); The word "malformed" should be outside the %<%>. +Warn about GCC format strings with strings unsuitable for diagnostics.. This help text should end with one '.', no

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

2019-05-20 Thread Joseph Myers
Another couple of issues in the change as committed: > + GCC_BAD ("%, ignored"); The word "malformed" should be outside the %<%>. > +Warn about GCC format strings with strings unsuitable for diagnostics.. This help text should end with one '.', not two. -- Joseph S. Myers jos...@codesou

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

2019-05-17 Thread David Malcolm
On Fri, 2019-05-17 at 12:07 -0600, Martin Sebor wrote: > On 5/17/19 11:16 AM, David Malcolm wrote: > > On Fri, 2019-05-17 at 09:02 -0600, Martin Sebor wrote: > > > On 5/17/19 7:43 AM, David Malcolm wrote: > > > > On Thu, 2019-05-16 at 18:40 -0600, Martin Sebor wrote: > > > > > On 5/16/19 5:22 PM, J

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

2019-05-17 Thread Martin Sebor
On 5/17/19 11:16 AM, David Malcolm wrote: On Fri, 2019-05-17 at 09:02 -0600, Martin Sebor wrote: On 5/17/19 7:43 AM, David Malcolm wrote: On Thu, 2019-05-16 at 18:40 -0600, Martin Sebor wrote: On 5/16/19 5:22 PM, Joseph Myers wrote: On Tue, 14 May 2019, Martin Sebor wrote: The attached patc

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

2019-05-17 Thread David Malcolm
On Fri, 2019-05-17 at 09:02 -0600, Martin Sebor wrote: > On 5/17/19 7:43 AM, David Malcolm wrote: > > On Thu, 2019-05-16 at 18:40 -0600, Martin Sebor wrote: > > > On 5/16/19 5:22 PM, Joseph Myers wrote: > > > > On Tue, 14 May 2019, Martin Sebor wrote: > > > > > > > > > The attached patch fixes quo

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

2019-05-17 Thread Martin Sebor
On 5/17/19 7:43 AM, David Malcolm wrote: On Thu, 2019-05-16 at 18:40 -0600, Martin Sebor wrote: On 5/16/19 5:22 PM, Joseph Myers wrote: On Tue, 14 May 2019, Martin Sebor wrote: The attached patch fixes quoting, spelling, and other formatting issues in diagnostics issued from files in the c-fa

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

2019-05-17 Thread David Malcolm
On Thu, 2019-05-16 at 18:40 -0600, Martin Sebor wrote: > On 5/16/19 5:22 PM, Joseph Myers wrote: > > On Tue, 14 May 2019, Martin Sebor wrote: > > > > > The attached patch fixes quoting, spelling, and other formatting > > > issues in diagnostics issued from files in the c-family/ > > > directory >

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

2019-05-16 Thread Martin Sebor
On 5/16/19 5:22 PM, Joseph Myers wrote: On Tue, 14 May 2019, Martin Sebor wrote: The attached patch fixes quoting, spelling, and other formatting issues in diagnostics issued from files in the c-family/ directory and pointed out by the -Wformat-diag warning. Some of the changes in this patch

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

2019-05-16 Thread Joseph Myers
On Tue, 14 May 2019, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued from files in the c-family/ directory > and pointed out by the -Wformat-diag warning. Some of the changes in this patch are questionable. The diagnostics for

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued from files in the c-family/ directory > and pointed out by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-c-family.diff > > gcc/c-family/ChangeLog