Re: Re: [PATCH 4/5] RISC-V: Add Zcmp extension supports.

2023-05-12 Thread Fei Gao
t At:2023 May 6 (Sat.) 16:53 >Recipient:Sinan >Cc:jiawei ; gcc-patches >Subject:Re: Re: [PATCH 4/5] RISC-V: Add Zcmp extension supports. >On 2023-05-05 23:57 Sinan wrote: >> >>> hi Jiawei >>> >>> Please ignore my previous reply. I accidently sent t

Re: [PATCH 4/5] RISC-V: Add Zcmp extension supports.

2023-05-12 Thread Sinan via Gcc-patches
Hi, Kito and Jiawei I have noticed several comments are not accurate or no longer valid(e.g. only for zc 0.5) and they need an update or improvement. > + >> +namespace { >> + >> +/* >> + 1. preprocessing: >> + 1.1. if there is no push rtx, then just return. e.g. >> + (note 5 1 22 2 [bb 2] NOTE_INS

Re: Re: [PATCH 4/5] RISC-V: Add Zcmp extension supports.

2023-05-12 Thread Sinan via Gcc-patches
i Gao Sent At:2023 May 6 (Sat.) 16:53 Recipient:Sinan Cc:jiawei ; gcc-patches Subject:Re: Re: [PATCH 4/5] RISC-V: Add Zcmp extension supports. On 2023-05-05 23:57 Sinan wrote: > >> hi Jiawei >> >> Please ignore my previous reply. I accidently sent the email before I >>

Re: Re: [PATCH 4/5] RISC-V: Add Zcmp extension supports.

2023-05-06 Thread Fei Gao
On 2023-05-05 23:57  Sinan wrote: > >> hi Jiawei >> >> Please ignore my previous reply. I accidently sent the email before I >> finished it. >> Sorry for that! >> >> I downloaded the series of patches from you and found in some cases >> it fails to generate zcmp push and pop insns. >> >> TC: >> >

Re: [PATCH 4/5] RISC-V: Add Zcmp extension supports.

2023-05-05 Thread Sinan via Gcc-patches
> hi Jiawei > > Please ignore my previous reply. I accidently sent the email before I > finished it. > Sorry for that! > > I downloaded the series of patches from you and found in some cases > it fails to generate zcmp push and pop insns. > > TC: > > char my_getchar(); > int test_s0() > { > >

Re: [PATCH 4/5] RISC-V: Add Zcmp extension supports.

2023-05-04 Thread Kito Cheng via Gcc-patches
Could you rebase this patch, we have some changes on > All "zcmpe" means Zcmp with RVE extension. Use zcmp_rve instead, zcmpe seems like a new ext. name > diff --git a/gcc/config/riscv/riscv-zcmp-popret.cc > b/gcc/config/riscv/riscv-zcmp-popret.cc > new file mode 100644 > index 000..d7b