Re: [PATCH 4/5] Don't define NULL as 0 in C

2024-10-11 Thread Alejandro Colomar
On Fri, Oct 11, 2024 at 02:55:38PM GMT, Joseph Myers wrote: > On Fri, 11 Oct 2024, Alejandro Colomar wrote: > > > That was insane. > > > > Link: > > Signed-off-by: Alejandro Colomar > > --- > > gcc/testsuite/gcc.c-torture/execute/pr68143_1.c | 2 +- >

Re: [PATCH 4/5] Don't define NULL as 0 in C

2024-10-11 Thread Alejandro Colomar
Hi Joseph, On Fri, Oct 11, 2024 at 02:59:50PM GMT, Joseph Myers wrote: > On Fri, 11 Oct 2024, Alejandro Colomar wrote: > > > That was insane. > > Also please avoid such pejorative language in commit messages. The > libiberty code here is 30-40 years (or more) old; the definition would > have

Re: [PATCH 4/5] Don't define NULL as 0 in C

2024-10-11 Thread Joseph Myers
On Fri, 11 Oct 2024, Alejandro Colomar wrote: > That was insane. Also please avoid such pejorative language in commit messages. The libiberty code here is 30-40 years (or more) old; the definition would have made a lot more sense in a pre-standard C context when it was written. -- Joseph S.

Re: [PATCH 4/5] Don't define NULL as 0 in C

2024-10-11 Thread Joseph Myers
On Fri, 11 Oct 2024, Alejandro Colomar wrote: > That was insane. > > Link: > Signed-off-by: Alejandro Colomar > --- > gcc/testsuite/gcc.c-torture/execute/pr68143_1.c | 2 +- > gcc/testsuite/gcc.c-torture/execute/pr70566.c | 2 +- > gcc/testsuite/gc