Re: [PATCH 4/4] openacc: Allow strided arrays in update directives

2021-02-04 Thread Julian Brown
On Thu, 4 Feb 2021 16:03:44 +0100 Tobias Burnus wrote: > LGTM. > > However, I'd feel better if there were a testcase, which actually > checks that it works correctly. (I think that means a > libgomp/testsuite/ run test.) Thanks! FYI, I've committed this version with an additional runtime test.

Re: [PATCH 4/4] openacc: Allow strided arrays in update directives

2021-02-04 Thread Tobias Burnus
LGTM. However, I'd feel better if there were a testcase, which actually checks that it works correctly. (I think that means a libgomp/testsuite/ run test.) Tobias On 02.02.21 14:28, Julian Brown wrote: OpenACC 3.0 ("2.14.4. Update Directive") states: Noncontiguous subarrays may appear. It

Re: [PATCH 4/4] openacc: Allow strided arrays in update directives

2021-02-04 Thread Tobias Burnus
LGTM. However, I'd feel better if there were a testcase, which actually checks that it works correctly. (I think that means a libgomp/testsuite/ run test.) Tobias On 02.02.21 14:28, Julian Brown wrote: OpenACC 3.0 ("2.14.4. Update Directive") states: Noncontiguous subarrays may appear. It