Re: [PATCH 4/4] Replace line_map union with C++ class hierarchy

2015-05-14 Thread Jeff Law
On 05/04/2015 03:27 PM, David Malcolm wrote: @@ -158,7 +158,7 @@ expand_location_1 (source_location loc, location (toward the expansion point) that is not reserved; that is, the first location that is in real source code. */ loc = linemap_unwind_to_first_non_r

Re: [PATCH 4/4] Replace line_map union with C++ class hierarchy

2015-05-04 Thread Jeff Law
On 05/01/2015 06:56 PM, David Malcolm wrote: This patch eliminates the union in struct line_map in favor of a simple class hierarchy, making struct line_map a base class, with line_map_ordinary and line_map_macro subclasses. The patch eliminates all usage of linemap_check_ordinary and linemap_ch