Re: [PATCH 3/4] libstdc++: Add floating-point std::to_chars implementation

2020-12-21 Thread Maciej W. Rozycki
On Mon, 21 Dec 2020, Patrick Palka wrote: > > This breaks with the `vax-netbsdelf' target in GCC compilation: > > > > .../libstdc++-v3/src/c++17/floating_to_chars.cc:126:38: error: static > > assertion failed > > 126 | static_assert(__DBL_MANT_DIG__ == 53); > > |

Re: [PATCH 3/4] libstdc++: Add floating-point std::to_chars implementation

2020-12-21 Thread Patrick Palka via Gcc-patches
On Sun, 20 Dec 2020, Maciej W. Rozycki wrote: > On Thu, 17 Dec 2020, Patrick Palka via Gcc-patches wrote: > > > > >libstdc++-v3/ChangeLog: > > > > > > > > * config/abi/pre/gnu.ver: Add new exports. > > > > * include/std/charconv (to_chars): Declare the floating-point > > > > ove

Re: [PATCH 3/4] libstdc++: Add floating-point std::to_chars implementation

2020-12-20 Thread Maciej W. Rozycki
On Thu, 17 Dec 2020, Patrick Palka via Gcc-patches wrote: > > >libstdc++-v3/ChangeLog: > > > > > > * config/abi/pre/gnu.ver: Add new exports. > > > * include/std/charconv (to_chars): Declare the floating-point > > > overloads for float, double and long double. > > > * src/c

Re: [PATCH 3/4] libstdc++: Add floating-point std::to_chars implementation

2020-12-18 Thread Christophe Lyon via Gcc-patches
Le ven. 18 déc. 2020 à 18:03, Patrick Palka a écrit : > On Fri, 18 Dec 2020, Christophe Lyon wrote: > > > On Fri, 18 Dec 2020 at 16:00, Patrick Palka wrote: > > > > > > On Fri, 18 Dec 2020, Christophe Lyon wrote: > > > > > > > Hi, > > > > > > > > > > > > On Fri, 18 Dec 2020 at 05:13, Patrick Pal

Re: [PATCH 3/4] libstdc++: Add floating-point std::to_chars implementation

2020-12-18 Thread Patrick Palka via Gcc-patches
On Fri, 18 Dec 2020, Christophe Lyon wrote: > On Fri, 18 Dec 2020 at 16:00, Patrick Palka wrote: > > > > On Fri, 18 Dec 2020, Christophe Lyon wrote: > > > > > Hi, > > > > > > > > > On Fri, 18 Dec 2020 at 05:13, Patrick Palka via Gcc-patches > > > wrote: > > > > > > > > On Thu, Dec 17, 2020 at 9:

Re: [PATCH 3/4] libstdc++: Add floating-point std::to_chars implementation

2020-12-18 Thread Christophe Lyon via Gcc-patches
On Fri, 18 Dec 2020 at 16:00, Patrick Palka wrote: > > On Fri, 18 Dec 2020, Christophe Lyon wrote: > > > Hi, > > > > > > On Fri, 18 Dec 2020 at 05:13, Patrick Palka via Gcc-patches > > wrote: > > > > > > On Thu, Dec 17, 2020 at 9:32 AM Jonathan Wakely > > > wrote: > > > > > > > > On 19/08/20 17

Re: [PATCH 3/4] libstdc++: Add floating-point std::to_chars implementation

2020-12-18 Thread Patrick Palka via Gcc-patches
On Fri, 18 Dec 2020, Christophe Lyon wrote: > Hi, > > > On Fri, 18 Dec 2020 at 05:13, Patrick Palka via Gcc-patches > wrote: > > > > On Thu, Dec 17, 2020 at 9:32 AM Jonathan Wakely wrote: > > > > > > On 19/08/20 17:57 -0400, Patrick Palka via Libstdc++ wrote: > > > >On Wed, 22 Jul 2020, Patric

Re: [PATCH 3/4] libstdc++: Add floating-point std::to_chars implementation

2020-12-18 Thread Jonathan Wakely via Gcc-patches
I think we can test for it with #ifdef and just provide an incorrectly rounded result for newlib.

Re: [PATCH 3/4] libstdc++: Add floating-point std::to_chars implementation

2020-12-18 Thread Christophe Lyon via Gcc-patches
Hi, On Fri, 18 Dec 2020 at 05:13, Patrick Palka via Gcc-patches wrote: > > On Thu, Dec 17, 2020 at 9:32 AM Jonathan Wakely wrote: > > > > On 19/08/20 17:57 -0400, Patrick Palka via Libstdc++ wrote: > > >On Wed, 22 Jul 2020, Patrick Palka wrote: > > > > > >> On Mon, 20 Jul 2020, Patrick Palka wr

Re: [PATCH 3/4] libstdc++: Add floating-point std::to_chars implementation

2020-12-17 Thread Patrick Palka via Gcc-patches
On Thu, Dec 17, 2020 at 9:32 AM Jonathan Wakely wrote: > > On 19/08/20 17:57 -0400, Patrick Palka via Libstdc++ wrote: > >On Wed, 22 Jul 2020, Patrick Palka wrote: > > > >> On Mon, 20 Jul 2020, Patrick Palka wrote: > >> > >> > On Mon, 20 Jul 2020, Jonathan Wakely wrote: > >> > > >> > > On 20/07/20

Re: [PATCH 3/4] libstdc++: Add floating-point std::to_chars implementation

2020-12-17 Thread Jonathan Wakely via Gcc-patches
On 19/08/20 17:57 -0400, Patrick Palka via Libstdc++ wrote: On Wed, 22 Jul 2020, Patrick Palka wrote: On Mon, 20 Jul 2020, Patrick Palka wrote: > On Mon, 20 Jul 2020, Jonathan Wakely wrote: > > > On 20/07/20 08:53 -0400, Patrick Palka via Libstdc++ wrote: > > > On Mon, 20 Jul 2020, Jonathan Wa

Re: [PATCH 3/4] libstdc++: Add floating-point std::to_chars implementation

2020-08-19 Thread Patrick Palka via Gcc-patches
On Wed, 22 Jul 2020, Patrick Palka wrote: > On Mon, 20 Jul 2020, Patrick Palka wrote: > > > On Mon, 20 Jul 2020, Jonathan Wakely wrote: > > > > > On 20/07/20 08:53 -0400, Patrick Palka via Libstdc++ wrote: > > > > On Mon, 20 Jul 2020, Jonathan Wakely wrote: > > > > > > > > > On 19/07/20 23:37 -

Re: [PATCH 3/4] libstdc++: Add floating-point std::to_chars implementation

2020-07-22 Thread Patrick Palka via Gcc-patches
On Mon, 20 Jul 2020, Patrick Palka wrote: > On Mon, 20 Jul 2020, Jonathan Wakely wrote: > > > On 20/07/20 08:53 -0400, Patrick Palka via Libstdc++ wrote: > > > On Mon, 20 Jul 2020, Jonathan Wakely wrote: > > > > > > > On 19/07/20 23:37 -0400, Patrick Palka via Libstdc++ wrote: > > > > > On Fri,

Re: [PATCH 3/4] libstdc++: Add floating-point std::to_chars implementation

2020-07-20 Thread Patrick Palka via Gcc-patches
On Mon, 20 Jul 2020, Jonathan Wakely wrote: > On 20/07/20 08:53 -0400, Patrick Palka via Libstdc++ wrote: > > On Mon, 20 Jul 2020, Jonathan Wakely wrote: > > > > > On 19/07/20 23:37 -0400, Patrick Palka via Libstdc++ wrote: > > > > On Fri, 17 Jul 2020, Patrick Palka wrote: > > > > > > > > > On Fr

Re: [PATCH 3/4] libstdc++: Add floating-point std::to_chars implementation

2020-07-20 Thread Jonathan Wakely via Gcc-patches
On 20/07/20 08:53 -0400, Patrick Palka via Libstdc++ wrote: On Mon, 20 Jul 2020, Jonathan Wakely wrote: On 19/07/20 23:37 -0400, Patrick Palka via Libstdc++ wrote: > On Fri, 17 Jul 2020, Patrick Palka wrote: > > > On Fri, 17 Jul 2020, Patrick Palka wrote: > > > > > On Wed, 15 Jul 2020, Patrick

Re: [PATCH 3/4] libstdc++: Add floating-point std::to_chars implementation

2020-07-20 Thread Patrick Palka via Gcc-patches
On Mon, 20 Jul 2020, Jonathan Wakely wrote: > On 19/07/20 23:37 -0400, Patrick Palka via Libstdc++ wrote: > > On Fri, 17 Jul 2020, Patrick Palka wrote: > > > > > On Fri, 17 Jul 2020, Patrick Palka wrote: > > > > > > > On Wed, 15 Jul 2020, Patrick Palka wrote: > > > > > > > > > On Tue, 14 Jul 202

Re: [PATCH 3/4] libstdc++: Add floating-point std::to_chars implementation

2020-07-20 Thread Jonathan Wakely via Gcc-patches
On 19/07/20 23:37 -0400, Patrick Palka via Libstdc++ wrote: On Fri, 17 Jul 2020, Patrick Palka wrote: On Fri, 17 Jul 2020, Patrick Palka wrote: > On Wed, 15 Jul 2020, Patrick Palka wrote: > > > On Tue, 14 Jul 2020, Patrick Palka wrote: > > > > > This implements the floating-point std::to_chars

Re: [PATCH 3/4] libstdc++: Add floating-point std::to_chars implementation

2020-07-19 Thread Patrick Palka via Gcc-patches
On Fri, 17 Jul 2020, Patrick Palka wrote: > On Fri, 17 Jul 2020, Patrick Palka wrote: > > > On Wed, 15 Jul 2020, Patrick Palka wrote: > > > > > On Tue, 14 Jul 2020, Patrick Palka wrote: > > > > > > > This implements the floating-point std::to_chars overloads for float, > > > > double and long d

Re: [PATCH 3/4] libstdc++: Add floating-point std::to_chars implementation

2020-07-17 Thread Patrick Palka via Gcc-patches
On Fri, 17 Jul 2020, Patrick Palka wrote: > On Wed, 15 Jul 2020, Patrick Palka wrote: > > > On Tue, 14 Jul 2020, Patrick Palka wrote: > > > > > This implements the floating-point std::to_chars overloads for float, > > > double and long double. We use the Ryu library to compute the shortest > >

Re: [PATCH 3/4] libstdc++: Add floating-point std::to_chars implementation

2020-07-16 Thread Patrick Palka via Gcc-patches
On Wed, 15 Jul 2020, Patrick Palka wrote: > On Tue, 14 Jul 2020, Patrick Palka wrote: > > > This implements the floating-point std::to_chars overloads for float, > > double and long double. We use the Ryu library to compute the shortest > > round-trippable fixed and scientific forms of a number

Re: [PATCH 3/4] libstdc++: Add floating-point std::to_chars implementation

2020-07-15 Thread Patrick Palka via Gcc-patches
On Tue, 14 Jul 2020, Patrick Palka wrote: > This implements the floating-point std::to_chars overloads for float, > double and long double. We use the Ryu library to compute the shortest > round-trippable fixed and scientific forms of a number for float, double > and long double. We also use Ryu