Re: [PATCH 3/4] Add Visium support to gcc

2015-01-05 Thread Eric Botcazou
> I'm a little concerned it's too loose. Basically it says that if both > modes are integer modes, then they're tieable. However, > HARD_REGNO_MODE_OK may return different values for MODE1 and MODE2, even > if both are integer modes. > > My recollection is if MODES_TIEABLE_P returns true for mod

Re: [PATCH 3/4] Add Visium support to gcc

2015-01-05 Thread Jeff Law
On 01/03/15 08:16, Eric Botcazou wrote: I'm a little concerned about the MODES_TIEABLE_P definition, but if it's working, I wouldn't mess with it. Could you elaborate? Do you find it too restrictive? I'm a little concerned it's too loose. Basically it says that if both modes are integer mo

Re: [PATCH 3/4] Add Visium support to gcc

2015-01-03 Thread Eric Botcazou
> I don't see anything particularly offensive. Actually it looks like a > reasonably clean RISC port. Thanks for the review. > I'm a little concerned about the MODES_TIEABLE_P definition, but if it's > working, I wouldn't mess with it. Could you elaborate? Do you find it too restrictive? > An

Re: [PATCH 3/4] Add Visium support to gcc

2014-12-23 Thread Jeff Law
On 12/22/14 04:14, Eric Botcazou wrote: Revised version after Joseph's comments and latest libgcc changes. gcc/ChangeLog 2014-12-22 Eric Botcazou * config.gcc: Add Visium support. * configure.ac: Likewise. * configure: Regenerate. * doc/extend.texi (interrup

Re: [PATCH 3/4] Add Visium support to gcc

2014-12-22 Thread Eric Botcazou
Revised version after Joseph's comments and latest libgcc changes. gcc/ChangeLog 2014-12-22 Eric Botcazou * config.gcc: Add Visium support. * configure.ac: Likewise. * configure: Regenerate. * doc/extend.texi (interrupt attribute): Add Visium. * doc/in

Re: [PATCH 3/4] Add Visium support to gcc

2014-12-20 Thread Eric Botcazou
> First, bootstrap a native compiler from current trunk. Then, use that > native compiler to build the cross compiler configured with > --enable-werror-always. (--enable-werror-always is only expected to work > when GCC is being built with the same version of GCC, as the compiler may > not be -We

Re: [PATCH 3/4] Add Visium support to gcc

2014-12-16 Thread Joseph Myers
On Mon, 15 Dec 2014, Eric Botcazou wrote: > > (and you should verify that the port builds cleanly with --enable-werror > > -always, for both 32-bit and 64-bit hosts, when building using current > > trunk > > GCC). > > Do you mean a bootstrap of the cross-compiler with --enable-werror-always on

Re: [PATCH 3/4] Add Visium support to gcc

2014-12-15 Thread Eric Botcazou
> Use of `%s' in diagnostics is long obsoleted by %qs (in this case, using > %qE with the identifier directly, rather than using IDENTIFIER_POINTER, is > preferred). Only occurrence fixed by mimicing the i386 port. > INTVAL / UINTVAL return HOST_WIDE_INT / unsigned HOST_WIDE_INT, not long / > uns

Re: [PATCH 3/4] Add Visium support to gcc

2014-12-11 Thread Hans-Peter Nilsson
On Fri, 12 Dec 2014, Joseph Myers wrote: > At least one target for this port should be added to > contrib/config-list.mk (and you should verify that the port builds cleanly > with --enable-werror-always, for both 32-bit and 64-bit hosts, when > building using current trunk GCC). While doing that,

Re: [PATCH 3/4] Add Visium support to gcc

2014-12-11 Thread Joseph Myers
Use of `%s' in diagnostics is long obsoleted by %qs (in this case, using %qE with the identifier directly, rather than using IDENTIFIER_POINTER, is preferred). INTVAL / UINTVAL return HOST_WIDE_INT / unsigned HOST_WIDE_INT, not long / unsigned long. You have lots of uses of fprintf that presum