Re: [PATCH 3/3] arm-linux: Add libitm support.

2011-12-16 Thread Joseph S. Myers
On Sat, 10 Dec 2011, Richard Henderson wrote: > +/* Begin by defaulting to whatever options were given to the compiler. */ > +int GTM_hwcap HIDDEN = 0 > +#ifdef __VFP_FP__ > + | HWCAP_ARM_VFP > +#endif > +#ifdef __IWMMXT__ > + | HWCAP_ARM_IWMMXT > +#endif > + ; It doesn't matter much since th

Re: [PATCH 3/3] arm-linux: Add libitm support.

2011-12-14 Thread Richard Henderson
On 12/14/2011 10:25 AM, Richard Earnshaw wrote: > Otherwise, with the changes for Ramana's comments, this is OK. For the record, this is the patch as committed. r~ commit dd120a9705b6c48fdb519e837ad47e41d155f50b Author: rth Date: Thu Dec 15 03:24:05 2011 + arm-linux: Add libitm supp

Re: [PATCH 3/3] arm-linux: Add libitm support.

2011-12-14 Thread Richard Henderson
On 12/14/2011 10:25 AM, Richard Earnshaw wrote: > On 10/12/11 23:21, Richard Henderson wrote: >> diff --git a/libitm/config/arm/hwcap.h b/libitm/config/arm/hwcap.h >> new file mode 100644 >> index 000..16e4034 >> --- /dev/null >> +++ b/libitm/config/arm/hwcap.h >> + >> +/* The following must ma

Re: [PATCH 3/3] arm-linux: Add libitm support.

2011-12-14 Thread Richard Earnshaw
On 10/12/11 23:21, Richard Henderson wrote: > diff --git a/libitm/config/arm/hwcap.h b/libitm/config/arm/hwcap.h > new file mode 100644 > index 000..16e4034 > --- /dev/null > +++ b/libitm/config/arm/hwcap.h > + > +/* The following must match the kernel's . */ > +#define HWCAP_ARM_SWP

Re: [PATCH 3/3] arm-linux: Add libitm support.

2011-12-12 Thread Richard Henderson
Four small patches relative to the last set. (1) Big thinko in how to set the EQ condition from the strex results. And surprisingly that wrong condition PASSES a large portion of the testsuite, by running through the ll/sc loop twice, with the first time being truly successful and the

Re: [PATCH 3/3] arm-linux: Add libitm support.

2011-12-12 Thread Ramana Radhakrishnan
Hi Richard, Comments inline below.. On Sat, Dec 10, 2011 at 03:21:23PM -0800, Richard Henderson wrote: > --- > libitm/Makefile.am |3 + > libitm/Makefile.in | 20 +++-- > libitm/config/arm/hwcap.cc | 67 + > libitm/config/arm