Re: [PATCH 3/3] Improve -Wmissing-indentation heuristics

2015-06-22 Thread Jeff Law
On 06/09/2015 11:31 AM, Patrick Palka wrote: This patch improves the heuristics of the warning in a number of ways. The improvements are hopefully adequately documented in the code comments. The additions to the test case also highlight the improvements. I tested an earlier version of this patc

Re: [PATCH 3/3] Improve -Wmissing-indentation heuristics

2015-06-22 Thread Jeff Law
On 06/18/2015 10:57 AM, Patrick Palka wrote: [ big snip ] These bogus warnings are pre-existing, however (i.e. not caused by this patch). (nods) Fixing the false positives from libpng/bdwgc sounds like a separate issue and thus a separate patch then. Agreed. jeff

Re: [PATCH 3/3] Improve -Wmissing-indentation heuristics

2015-06-18 Thread Patrick Palka
On Thu, Jun 18, 2015 at 12:57 PM, Patrick Palka wrote: > On Thu, Jun 18, 2015 at 12:31 PM, David Malcolm wrote: >> On Tue, 2015-06-09 at 13:31 -0400, Patrick Palka wrote: >>> This patch improves the heuristics of the warning in a number of ways. >>> The improvements are hopefully adequately docum

Re: [PATCH 3/3] Improve -Wmissing-indentation heuristics

2015-06-18 Thread Patrick Palka
On Thu, Jun 18, 2015 at 12:31 PM, David Malcolm wrote: > On Tue, 2015-06-09 at 13:31 -0400, Patrick Palka wrote: >> This patch improves the heuristics of the warning in a number of ways. >> The improvements are hopefully adequately documented in the code >> comments. >> >> The additions to the tes

Re: [PATCH 3/3] Improve -Wmissing-indentation heuristics

2015-06-18 Thread David Malcolm
On Tue, 2015-06-09 at 13:31 -0400, Patrick Palka wrote: > This patch improves the heuristics of the warning in a number of ways. > The improvements are hopefully adequately documented in the code > comments. > > The additions to the test case also highlight the improvements. > > I tested an earli