Re: [PATCH 3/3] Fix ubsan tests by disabling of an optimization.

2015-07-10 Thread Jeff Law
On 07/10/2015 02:19 AM, Richard Biener wrote: But the warning on the "bogus" line will still be warranted, so user goes and fixes it. But when the user gets the "bogus" line, he may look at the code and determine that the reported line can't possibly be executed -- so they get confused, assume

Re: [PATCH 3/3] Fix ubsan tests by disabling of an optimization.

2015-07-10 Thread Richard Biener
On Thu, Jul 9, 2015 at 6:37 PM, Jeff Law wrote: > On 07/09/2015 09:41 AM, Jakub Jelinek wrote: >> >> On Thu, Jul 09, 2015 at 09:34:25AM -0600, Jeff Law wrote: >>> >>> On 07/09/2015 08:13 AM, Jakub Jelinek wrote: On Thu, Jul 09, 2015 at 03:56:35PM +0200, mliska wrote: > > ---

Re: [PATCH 3/3] Fix ubsan tests by disabling of an optimization.

2015-07-09 Thread Jeff Law
On 07/09/2015 09:41 AM, Jakub Jelinek wrote: On Thu, Jul 09, 2015 at 09:34:25AM -0600, Jeff Law wrote: On 07/09/2015 08:13 AM, Jakub Jelinek wrote: On Thu, Jul 09, 2015 at 03:56:35PM +0200, mliska wrote: --- gcc/testsuite/g++.dg/ubsan/vptr-1.C | 2 +- gcc/testsuite/g++.dg/ubsan/vptr-2.C | 2

Re: [PATCH 3/3] Fix ubsan tests by disabling of an optimization.

2015-07-09 Thread Jakub Jelinek
On Thu, Jul 09, 2015 at 09:34:25AM -0600, Jeff Law wrote: > On 07/09/2015 08:13 AM, Jakub Jelinek wrote: > >On Thu, Jul 09, 2015 at 03:56:35PM +0200, mliska wrote: > >>--- > >> gcc/testsuite/g++.dg/ubsan/vptr-1.C | 2 +- > >> gcc/testsuite/g++.dg/ubsan/vptr-2.C | 2 +- > >> gcc/testsuite/g++.dg/ub

Re: [PATCH 3/3] Fix ubsan tests by disabling of an optimization.

2015-07-09 Thread Jeff Law
On 07/09/2015 08:13 AM, Jakub Jelinek wrote: On Thu, Jul 09, 2015 at 03:56:35PM +0200, mliska wrote: --- gcc/testsuite/g++.dg/ubsan/vptr-1.C | 2 +- gcc/testsuite/g++.dg/ubsan/vptr-2.C | 2 +- gcc/testsuite/g++.dg/ubsan/vptr-3.C | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) I'd

Re: [PATCH 3/3] Fix ubsan tests by disabling of an optimization.

2015-07-09 Thread Jakub Jelinek
On Thu, Jul 09, 2015 at 03:56:35PM +0200, mliska wrote: > --- > gcc/testsuite/g++.dg/ubsan/vptr-1.C | 2 +- > gcc/testsuite/g++.dg/ubsan/vptr-2.C | 2 +- > gcc/testsuite/g++.dg/ubsan/vptr-3.C | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) I'd actually think it would be better to give