Re: [PATCH 3/3] Fix condition for std::variant to be copy constructible

2019-04-19 Thread Jonathan Wakely
On 17/04/19 17:12 +0100, Jonathan Wakely wrote: The standard says the std::variant copy constructor is defined as deleted unless all alternative types are copy constructible, but we were making it also depend on move constructible. It turns out that was changed by https://wg21.link/lwg2904 and

Re: [PATCH 3/3] Fix condition for std::variant to be copy constructible

2019-04-17 Thread Jonathan Wakely
On 17/04/19 19:20 +0300, Ville Voutilainen wrote: On Wed, 17 Apr 2019 at 19:12, Jonathan Wakely wrote: The standard says the std::variant copy constructor is defined as deleted unless all alternative types are copy constructible, but we were making it also depend on move constructible. Fix the

Re: [PATCH 3/3] Fix condition for std::variant to be copy constructible

2019-04-17 Thread Ville Voutilainen
On Wed, 17 Apr 2019 at 19:12, Jonathan Wakely wrote: > > The standard says the std::variant copy constructor is defined as > deleted unless all alternative types are copy constructible, but we were > making it also depend on move constructible. Fix the condition and > enhance the tests to check th