Re: [PATCH 3/3][GCC][AARCH64] Add support for pointer authentication B key

2019-05-30 Thread Sam Tebbs
The fix has been committed as r271780. Apologies for the failure everyone. Sam On 29/05/2019 15:22, Sam Tebbs wrote: > Thanks for finding this Christoph, I had this failure a while ago but it > stopped happening so I thought all was good. I have a fix ready. > > Sam > > On 29/05/2019 12:22, Chris

Re: [PATCH 3/3][GCC][AARCH64] Add support for pointer authentication B key

2019-05-29 Thread Sam Tebbs
Thanks for finding this Christoph, I had this failure a while ago but it stopped happening so I thought all was good. I have a fix ready. Sam On 29/05/2019 12:22, Christophe Lyon wrote: > On Wed, 29 May 2019 at 11:23, Sam Tebbs wrote: >> The libgcc changes have been acknowledged off-list. Commi

Re: [PATCH 3/3][GCC][AARCH64] Add support for pointer authentication B key

2019-05-29 Thread Christophe Lyon
On Wed, 29 May 2019 at 11:23, Sam Tebbs wrote: > > The libgcc changes have been acknowledged off-list. Committed as r271735. > After this commit, I'm seeing errors while building libstdc++: 0x11c29f3 aarch64_return_address_signing_enabled() /tmp/8467855_6.tmpdir/aci-gcc-fsf/sources/gcc-f

Re: [PATCH 3/3][GCC][AARCH64] Add support for pointer authentication B key

2019-05-29 Thread Sam Tebbs
The libgcc changes have been acknowledged off-list. Committed as r271735. On 01/03/2019 14:12, Sam Tebbs wrote: > On 31/01/2019 14:54, Sam Tebbs wrote: >> >>> ping 3. The preceding two patches were committed a while ago but require >>> the minor libgcc changes in this patch, which are the only pa

Re: [PATCH 3/3][GCC][AARCH64] Add support for pointer authentication B key

2019-03-01 Thread Sam Tebbs
On 31/01/2019 14:54, Sam Tebbs wrote: > >> ping 3. The preceding two patches were committed a while ago but require >> the minor libgcc changes in this patch, which are the only parts left to >> be reviewed. > ping 4 Attached is a rebased patch made to work on top of Sudi Das' BTI patch (by ren

Re: [PATCH 3/3][GCC][AARCH64] Add support for pointer authentication B key

2019-01-31 Thread Sam Tebbs
On 23/01/2019 10:22, Sam Tebbs wrote: > On 14/01/2019 10:43, Kyrill Tkachov wrote: > >> On 08/01/19 11:38, Sam Tebbs wrote: >> >> >> >> On 1/7/19 6:28 PM, James Greenhalgh wrote: >> >> > On Fri, Dec 21, 2018 at 09:00:10AM -0600, Sam Tebbs wrote: >> >> >> On 11/9/18 11:04 AM, Sam Tebbs wrote: >> >>

Re: [PATCH 3/3][GCC][AARCH64] Add support for pointer authentication B key

2019-01-23 Thread Sam Tebbs
On 14/01/2019 10:43, Kyrill Tkachov wrote: > > On 08/01/19 11:38, Sam Tebbs wrote: >> >> On 1/7/19 6:28 PM, James Greenhalgh wrote: >> > On Fri, Dec 21, 2018 at 09:00:10AM -0600, Sam Tebbs wrote: >> >> On 11/9/18 11:04 AM, Sam Tebbs wrote: >> > >> > >> > >> >> Attached is an improved patch with "

Re: [PATCH 3/3][GCC][AARCH64] Add support for pointer authentication B key

2019-01-14 Thread Kyrill Tkachov
On 08/01/19 11:38, Sam Tebbs wrote: On 1/7/19 6:28 PM, James Greenhalgh wrote: > On Fri, Dec 21, 2018 at 09:00:10AM -0600, Sam Tebbs wrote: >> On 11/9/18 11:04 AM, Sam Tebbs wrote: > > > >> Attached is an improved patch with "hint" removed from the test scans, >> pauth_hint_num_a and pauth_hi

Re: [PATCH 3/3][GCC][AARCH64] Add support for pointer authentication B key

2019-01-08 Thread Sam Tebbs
On 1/7/19 6:28 PM, James Greenhalgh wrote: > On Fri, Dec 21, 2018 at 09:00:10AM -0600, Sam Tebbs wrote: >> On 11/9/18 11:04 AM, Sam Tebbs wrote: > > > >> Attached is an improved patch with "hint" removed from the test scans, >> pauth_hint_num_a and pauth_hint_num_b merged into pauth_hint_num a

Re: [PATCH 3/3][GCC][AARCH64] Add support for pointer authentication B key

2019-01-07 Thread James Greenhalgh
On Fri, Dec 21, 2018 at 09:00:10AM -0600, Sam Tebbs wrote: > On 11/9/18 11:04 AM, Sam Tebbs wrote: > Attached is an improved patch with "hint" removed from the test scans, > pauth_hint_num_a and pauth_hint_num_b merged into pauth_hint_num and the > "gcc_assert (cfun->machine->frame.laid_out)"

Re: [PATCH 3/3][GCC][AARCH64] Add support for pointer authentication B key

2019-01-04 Thread Sam Tebbs
On 12/21/18 3:00 PM, Sam Tebbs wrote: > On 11/9/18 11:04 AM, Sam Tebbs wrote: >> On 11/02/2018 06:01 PM, Sam Tebbs wrote: >> >>> On 11/02/2018 05:35 PM, Sam Tebbs wrote: >>> Hi all, This patch adds support for the Armv8.3-A pointer authentication instructions that use the

Re: [PATCH 3/3][GCC][AARCH64] Add support for pointer authentication B key

2018-12-21 Thread Sam Tebbs
On 11/9/18 11:04 AM, Sam Tebbs wrote: > On 11/02/2018 06:01 PM, Sam Tebbs wrote: > >> On 11/02/2018 05:35 PM, Sam Tebbs wrote: >> >>> Hi all, >>> >>> This patch adds support for the Armv8.3-A pointer authentication >>> instructions >>> that use the B-key (pacib*, autib* and retab). This required a

Re: [PATCH 3/3][GCC][AARCH64] Add support for pointer authentication B key

2018-11-09 Thread Sam Tebbs
On 11/02/2018 06:01 PM, Sam Tebbs wrote: > On 11/02/2018 05:35 PM, Sam Tebbs wrote: > >> Hi all, >> >> This patch adds support for the Armv8.3-A pointer authentication instructions >> that use the B-key (pacib*, autib* and retab). This required adding builtins >> for >> pacib1716 and autib1716, a

Re: [PATCH 3/3][GCC][AARCH64] Add support for pointer authentication B key

2018-11-02 Thread Sam Tebbs
On 11/02/2018 05:35 PM, Sam Tebbs wrote: > Hi all, > > This patch adds support for the Armv8.3-A pointer authentication instructions > that use the B-key (pacib*, autib* and retab). This required adding builtins > for > pacib1716 and autib1716, adding the "b-key" feature to the -mbranch-protectio