Re: [PATCH 2/9] ENABLE_CHECKING refactoring: libcpp

2015-10-21 Thread Jeff Law
On 10/18/2015 06:56 PM, Mikhail Maltsev wrote: On 10/12/2015 11:57 PM, Jeff Law wrote: >On 10/06/2015 06:40 AM, Bernd Schmidt wrote: >>I'm not entirely sure what to make of this series. There seem to be good >>bits in there but also some things I find questionable. I'll add some >>comments on t

Re: [PATCH 2/9] ENABLE_CHECKING refactoring: libcpp

2015-10-21 Thread Jeff Law
On 10/06/2015 06:40 AM, Bernd Schmidt wrote: I'm not entirely sure what to make of this series. There seem to be good bits in there but also some things I find questionable. I'll add some comments on things that occur to me. On 10/06/2015 01:28 AM, Mikhail Maltsev wrote: * include/line-map

Re: [PATCH 2/9] ENABLE_CHECKING refactoring: libcpp

2015-10-18 Thread Mikhail Maltsev
On 10/12/2015 11:57 PM, Jeff Law wrote: > On 10/06/2015 06:40 AM, Bernd Schmidt wrote: >> I'm not entirely sure what to make of this series. There seem to be good >> bits in there but also some things I find questionable. I'll add some >> comments on things that occur to me. > Maybe we should start

Re: [PATCH 2/9] ENABLE_CHECKING refactoring: libcpp

2015-10-12 Thread Jeff Law
On 10/06/2015 06:40 AM, Bernd Schmidt wrote: I'm not entirely sure what to make of this series. There seem to be good bits in there but also some things I find questionable. I'll add some comments on things that occur to me. Maybe we should start pulling out the bits that we think are ready & go

Re: [PATCH 2/9] ENABLE_CHECKING refactoring: libcpp

2015-10-06 Thread Bernd Schmidt
I'm not entirely sure what to make of this series. There seem to be good bits in there but also some things I find questionable. I'll add some comments on things that occur to me. On 10/06/2015 01:28 AM, Mikhail Maltsev wrote: * include/line-map.h: Fix use of ENABLE_CHECKING. Fix ho

Re: [PATCH 2/9] ENABLE_CHECKING refactoring: libcpp

2015-10-05 Thread Mikhail Maltsev
libcpp/ChangeLog: 2015-10-05 Mikhail Maltsev * include/line-map.h: Fix use of ENABLE_CHECKING. * init.c: Likewise. * macro.c (struct macro_arg_token_iter, set_arg_token, macro_arg_token_iter_init, macro_arg_token_iter_forward, macro_arg_token_iter_get_to