Re: [PATCH 2/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-02-19 Thread Ilmir Usmanov
Hi Tobias! On 10.02.2014 03:10, Tobias Burnus wrote: Shouldn't you also reject polymorphic types ("BT_CLASS" and "BT_ASSUMED")? [BT_CLASS = "class(derived_type_name)" or "class(*)"; BT_ASSUMED = "type(*)"] + if (n->sym->attr.pointer) +gfc_error ("POINTER object '%s' in %s clause

Re: [PATCH 2/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-02-10 Thread Thomas Schwinge
Hi! On Mon, 10 Feb 2014 00:10:26 +0100, Tobias Burnus wrote: > Ilmir Usmanov wrote: > > OpenACC 1.0 fortran FE support -- matching and resolving. > > +static void > > +resolve_oacc_cache (gfc_code *) > > +{ > > + //TODO: resolve subarrays > > +} > > ;-) Just to clarify: I'm fine with inc

Re: [PATCH 2/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-02-09 Thread Tobias Burnus
Ilmir Usmanov wrote: OpenACC 1.0 fortran FE support -- matching and resolving. + return MATCH_ERROR; +} + +static match +match_oacc_clause_gang (gfc_omp_clauses *cp) +{ For consistency, can you add another empty line before the function? +#define OMP_CLAUSE_SEQ (1ll

Re: [PATCH 2/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-01-31 Thread Ilmir Usmanov
OpenACC 1.0 fortran FE support -- matching and resolving. * openmp.c (gfc_free_omp_clauses): Remove also OpenACC clauses. (gfc_free_exprlist): New function to clear expression list. (match_oacc_exprlist): New function to match expression list. (match_oacc_clause_gang): New fun

Re: [PATCH 2/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-01-24 Thread Thomas Schwinge
Hi! Regarding my comments, please keep in mind that I don't have a lot of Fortran experience; neither as a user nor as an implementor ;-) in the GCC front end, so don't hesitate to tell me if I'm misunderstanding something. As I suggested, it may make sense to CC Fortran front end maintainers for