Re: [PATCH 2/2] Rework 128-bit complex multiply and divide.

2023-03-09 Thread Michael Meissner via Gcc-patches
On Thu, Mar 09, 2023 at 04:16:21PM -0600, Segher Boessenkool wrote: > On Thu, Mar 09, 2023 at 11:11:34AM -0500, Michael Meissner wrote: > > On Fri, Mar 03, 2023 at 03:35:44PM -0600, Segher Boessenkool wrote: > > > > +/* { dg-final { scan-assembler "bl __divtc3" } } */ > > > > > > This name depends

Re: [PATCH 2/2] Rework 128-bit complex multiply and divide.

2023-03-09 Thread Segher Boessenkool
On Thu, Mar 09, 2023 at 11:11:34AM -0500, Michael Meissner wrote: > On Fri, Mar 03, 2023 at 03:35:44PM -0600, Segher Boessenkool wrote: > > > +/* { dg-final { scan-assembler "bl __divtc3" } } */ > > > > This name depends on what object format and ABI is in use (some have an > > extra leading under

Re: [PATCH 2/2] Rework 128-bit complex multiply and divide.

2023-03-09 Thread Michael Meissner via Gcc-patches
On Fri, Mar 03, 2023 at 03:35:44PM -0600, Segher Boessenkool wrote: > > +complex_multiply_builtin_code (machine_mode mode) > > +{ > > + return (built_in_function) (BUILT_IN_COMPLEX_MUL_MIN + mode > > + - MIN_MODE_COMPLEX_FLOAT); > > +} > > There should be an assert that th

Re: [PATCH 2/2] Rework 128-bit complex multiply and divide.

2023-03-09 Thread Michael Meissner via Gcc-patches
On Fri, Mar 03, 2023 at 03:35:44PM -0600, Segher Boessenkool wrote: > Hi! > > On Fri, Feb 03, 2023 at 12:53:05AM -0500, Michael Meissner wrote: > > This patch reworks how the complex multiply and divide built-in functions > > are > > done. > > > I tested all 3 patchs for PR target/107299 on: >

Re: [PATCH 2/2] Rework 128-bit complex multiply and divide.

2023-03-03 Thread Segher Boessenkool
Hi! On Fri, Feb 03, 2023 at 12:53:05AM -0500, Michael Meissner wrote: > This patch reworks how the complex multiply and divide built-in functions are > done. > I tested all 3 patchs for PR target/107299 on: Is this part of the proposed commit message? As Ke Wen pointed out, it is wrong. Most o

Re: [PATCH 2/2] Rework 128-bit complex multiply and divide.

2023-02-22 Thread Michael Meissner via Gcc-patches
On Wed, Feb 22, 2023 at 06:13:07PM +0800, Kewen.Lin wrote: > These two above paragraphs look a bit out of date (two patches now). :) Thanks. > IIUC this patch actually fixes a latent issue, so it is independent of the one > fixing the bootstrapping issue, right? This updated version of patch loo

Re: [PATCH 2/2] Rework 128-bit complex multiply and divide.

2023-02-22 Thread Kewen.Lin via Gcc-patches
Hi Mike, on 2023/2/3 13:53, Michael Meissner wrote: > This patch reworks how the complex multiply and divide built-in functions are > done. Previously we created built-in declarations for doing long double > complex > multiply and divide when long double is IEEE 128-bit. The old code also did