Re: [PATCH 2/2] DWARF: make it possible to emit debug info for declarations only

2017-06-21 Thread Pierre-Marie de Rodat
On 06/21/2017 09:11 AM, Richard Biener wrote: Sure, no obligation for you to enhance Fortran debug! Understood, thanks. For your information, I just committed the change. Thank you again for reviewing! -- Pierre-Marie de Rodat

Re: [PATCH 2/2] DWARF: make it possible to emit debug info for declarations only

2017-06-21 Thread Richard Biener
On Tue, Jun 20, 2017 at 4:34 PM, Pierre-Marie de Rodat wrote: > On 06/20/2017 02:16 PM, Richard Biener wrote: >> >> Nice. This looks ok. > > > Great, thank you! > >> I'm mildy curious about the deecrease of debuginfo size for cc1 -- did >> you spot anything obvious there? > > > Well, the benchmar

Re: [PATCH 2/2] DWARF: make it possible to emit debug info for declarations only

2017-06-20 Thread Pierre-Marie de Rodat
On 06/20/2017 02:16 PM, Richard Biener wrote: Nice. This looks ok. Great, thank you! I'm mildy curious about the deecrease of debuginfo size for cc1 -- did you spot anything obvious there? Well, the benchmark I exposed was for the whole file size, not just .debug_info section size. Just t

Re: [PATCH 2/2] DWARF: make it possible to emit debug info for declarations only

2017-06-20 Thread Richard Biener
On Fri, Jun 16, 2017 at 6:35 PM, Pierre-Marie de Rodat wrote: > On 05/31/2017 11:08 AM, Pierre-Marie de Rodat wrote: >> >> On 05/31/2017 09:34 AM, Richard Biener wrote: >>> >>> Actually for the bigger picture I'd refactor >>> rest_of_decl_compilation, not calling it from the frontends but >>> rely

Re: [PATCH 2/2] DWARF: make it possible to emit debug info for declarations only

2017-06-16 Thread Pierre-Marie de Rodat
On 05/31/2017 11:08 AM, Pierre-Marie de Rodat wrote: On 05/31/2017 09:34 AM, Richard Biener wrote: Actually for the bigger picture I'd refactor rest_of_decl_compilation, not calling it from the frontends but rely on finalize_decl/function. The missing part would then be calling the dwarf hook w

Re: [PATCH 2/2] DWARF: make it possible to emit debug info for declarations only

2017-05-31 Thread Pierre-Marie de Rodat
On 05/31/2017 09:34 AM, Richard Biener wrote: Actually for the bigger picture I'd refactor rest_of_decl_compilation, not calling it from the frontends but rely on finalize_decl/function. The missing part would then be calling the dwarf hook which should eventually be done at some of the places t

Re: [PATCH 2/2] DWARF: make it possible to emit debug info for declarations only

2017-05-31 Thread Richard Biener
On Tue, May 30, 2017 at 5:47 PM, Pierre-Marie de Rodat wrote: > Thank you for your review, Richard. > > On 05/30/2017 01:59 PM, Richard Biener wrote: >> >> I think the issue is unfortunate in the C frontend as well. So I believe >> we can >> go without a new langhook and instead make sure >> dwar

Re: [PATCH 2/2] DWARF: make it possible to emit debug info for declarations only

2017-05-30 Thread Pierre-Marie de Rodat
Thank you for your review, Richard. On 05/30/2017 01:59 PM, Richard Biener wrote: I think the issue is unfortunate in the C frontend as well. So I believe we can go without a new langhook and instead make sure dwarf2out_early_global_decl is not called for uninteresting decls (which means eventu

Re: [PATCH 2/2] DWARF: make it possible to emit debug info for declarations only

2017-05-30 Thread Richard Biener
On Mon, May 29, 2017 at 9:50 AM, Pierre-Marie de Rodat wrote: > Hello, > > The DWARF back-end used to systematically ignore file-scope function and > variable declarations. While this is justified in language like C/C++, > where such declarations can appear in several translation units and thus >

Re: [PATCH 2/2] DWARF: make it possible to emit debug info for declarations only

2017-05-29 Thread Pierre-Marie de Rodat
On 05/29/2017 09:50 AM, Pierre-Marie de Rodat wrote: Bootstrapped and reg-tested on x86_64-linux. Ok to commit? Thank you in advance! I just realized that I forgot to add the testcase: here it is, sorry! -- Pierre-Marie de Rodat -- { dg-options "-cargs -g -dA -margs" } -- { dg-final { scan-