Re: [PATCH 2/2] Add some more test cases for fentry and pg

2014-09-19 Thread Andi Kleen
This is the patch I committed. Should fix everyone's issues. Fix mcount test cases to only run on supported targets * gcc.dg/pg-override.c: Only run on x86 Linux. * gcc.dg/pg.c: Dito. * gcc.target/i386/fentry-override.c: Exclude for PIC. * gcc.

Re: [PATCH 2/2] Add some more test cases for fentry and pg

2014-09-17 Thread Andi Kleen
> Well, so why does Yo're right. It's actually not supported. I'll use the method you suggested earlier. -Andi

Re: [PATCH 2/2] Add some more test cases for fentry and pg

2014-09-17 Thread Jakub Jelinek
On Wed, Sep 17, 2014 at 05:46:45PM +0200, Andi Kleen wrote: > On Wed, Sep 17, 2014 at 04:51:33PM +0200, Jakub Jelinek wrote: > > On Wed, Sep 17, 2014 at 04:39:00PM +0200, Andi Kleen wrote: > > > Ok, this should fix it: > > > > > > I'll commit it as obvious after testing unless there are objections

Re: [PATCH 2/2] Add some more test cases for fentry and pg

2014-09-17 Thread Andi Kleen
On Wed, Sep 17, 2014 at 04:51:33PM +0200, Jakub Jelinek wrote: > On Wed, Sep 17, 2014 at 04:39:00PM +0200, Andi Kleen wrote: > > Ok, this should fix it: > > > > I'll commit it as obvious after testing unless there are objections. > > This isn't sufficient. > If -mfentry isn't compatible with -m32

Re: [PATCH 2/2] Add some more test cases for fentry and pg

2014-09-17 Thread Jakub Jelinek
On Wed, Sep 17, 2014 at 04:39:00PM +0200, Andi Kleen wrote: > Ok, this should fix it: > > I'll commit it as obvious after testing unless there are objections. This isn't sufficient. If -mfentry isn't compatible with -m32 -fpic, supposedly you need something like (untested): /* { dg-do compile { t

Re: [PATCH 2/2] Add some more test cases for fentry and pg

2014-09-17 Thread Andi Kleen
On Wed, Sep 17, 2014 at 04:32:21PM +0200, Andi Kleen wrote: > On Wed, Sep 17, 2014 at 03:42:37PM +0200, Dominique Dhumieres wrote: > > > > On darwin I get > > > > FAIL: gcc.target/i386/fentry-override.c (test for excess errors) > > UNRESOLVED: gcc.target/i386/fentry-override.c scan-assembler-not

Re: [PATCH 2/2] Add some more test cases for fentry and pg

2014-09-17 Thread Andi Kleen
On Wed, Sep 17, 2014 at 03:42:37PM +0200, Dominique Dhumieres wrote: > > On darwin I get > > FAIL: gcc.target/i386/fentry-override.c (test for excess errors) > UNRESOLVED: gcc.target/i386/fentry-override.c scan-assembler-not __fentry__ > FAIL: gcc.target/i386/fentry.c (test for excess errors) > U

Re: [PATCH 2/2] Add some more test cases for fentry and pg

2014-09-17 Thread Dominique Dhumieres
On darwin I get FAIL: gcc.target/i386/fentry-override.c (test for excess errors) UNRESOLVED: gcc.target/i386/fentry-override.c scan-assembler-not __fentry__ FAIL: gcc.target/i386/fentry.c (test for excess errors) UNRESOLVED: gcc.target/i386/fentry.c scan-assembler __fentry__ with -m32. The error

Re: [PATCH 2/2] Add some more test cases for fentry and pg

2014-09-16 Thread H.J. Lu
On Tue, Sep 16, 2014 at 8:36 AM, H.J. Lu wrote: > On Mon, Sep 15, 2014 at 8:59 AM, Andi Kleen wrote: >> On Mon, Sep 15, 2014 at 11:29:50AM +0200, Richard Biener wrote: >>> On Fri, Sep 12, 2014 at 4:32 PM, Andi Kleen wrote: >>> > From: Andi Kleen >>> > >>> > Test fentry and no_instrument_functio

Re: [PATCH 2/2] Add some more test cases for fentry and pg

2014-09-16 Thread H.J. Lu
On Mon, Sep 15, 2014 at 8:59 AM, Andi Kleen wrote: > On Mon, Sep 15, 2014 at 11:29:50AM +0200, Richard Biener wrote: >> On Fri, Sep 12, 2014 at 4:32 PM, Andi Kleen wrote: >> > From: Andi Kleen >> > >> > Test fentry and no_instrument_function overriding. >> > >> > No test cases for the LTO test f

Re: [PATCH 2/2] Add some more test cases for fentry and pg

2014-09-15 Thread Andi Kleen
On Mon, Sep 15, 2014 at 11:29:50AM +0200, Richard Biener wrote: > On Fri, Sep 12, 2014 at 4:32 PM, Andi Kleen wrote: > > From: Andi Kleen > > > > Test fentry and no_instrument_function overriding. > > > > No test cases for the LTO test for now, as the LTO > > harness doesn't seem to support diffe

Re: [PATCH 2/2] Add some more test cases for fentry and pg

2014-09-15 Thread Richard Biener
On Fri, Sep 12, 2014 at 4:32 PM, Andi Kleen wrote: > From: Andi Kleen > > Test fentry and no_instrument_function overriding. > > No test cases for the LTO test for now, as the LTO > harness doesn't seem to support different flags for the final > link. Sure it does - via dg-extra-ld-options (you