Re: [PATCH 1/6] Use IFN_SQRT in tree-vect-patterns.c

2015-11-10 Thread Richard Biener
On November 10, 2015 6:29:36 PM GMT+01:00, Joseph Myers wrote: >On Tue, 10 Nov 2015, Richard Biener wrote: > >> Looks ok but I wonder if this is dead code with >> >> (for pows (POW) >> sqrts (SQRT) >> cbrts (CBRT) >> (simplify >> (pows @0 REAL_CST@1) >> (with { >> const REAL_V

Re: [PATCH 1/6] Use IFN_SQRT in tree-vect-patterns.c

2015-11-10 Thread Joseph Myers
On Tue, 10 Nov 2015, Richard Biener wrote: > Looks ok but I wonder if this is dead code with > > (for pows (POW) > sqrts (SQRT) > cbrts (CBRT) > (simplify > (pows @0 REAL_CST@1) > (with { > const REAL_VALUE_TYPE *value = TREE_REAL_CST_PTR (@1); > REAL_VALUE_TYPE tmp; >}

Re: [PATCH 1/6] Use IFN_SQRT in tree-vect-patterns.c

2015-11-10 Thread Richard Biener
On Tue, Nov 10, 2015 at 11:57 AM, Richard Sandiford wrote: > Richard Biener writes: >> On Mon, Nov 9, 2015 at 5:21 PM, Richard Sandiford >> wrote: >>> In practice all targets that can vectorise sqrt define the appropriate >>> sqrt2 optab. The only case where this isn't immediately obvious >>> i

Re: [PATCH 1/6] Use IFN_SQRT in tree-vect-patterns.c

2015-11-10 Thread Richard Sandiford
Richard Biener writes: > On Mon, Nov 9, 2015 at 5:21 PM, Richard Sandiford > wrote: >> In practice all targets that can vectorise sqrt define the appropriate >> sqrt2 optab. The only case where this isn't immediately obvious >> is the libmass support in rs6000.c, but Mike Meissner said that it s

Re: [PATCH 1/6] Use IFN_SQRT in tree-vect-patterns.c

2015-11-10 Thread Richard Biener
On Mon, Nov 9, 2015 at 5:21 PM, Richard Sandiford wrote: > In practice all targets that can vectorise sqrt define the appropriate > sqrt2 optab. The only case where this isn't immediately obvious > is the libmass support in rs6000.c, but Mike Meissner said that it shouldn't > be exercised for sqr