Re: [PATCH 1/5] Refactor completely_scalarize_var

2015-08-27 Thread Alan Lawrence
Martin Jambor wrote: > > If you change what the function does, you have to change the comment > too. If I am not mistaken, even with the whole patch set applied, the > first sentence would still be: "Create total_scalarization accesses > for all scalar type fields in VAR and for VAR as a whole." A

Re: [PATCH 1/5] Refactor completely_scalarize_var

2015-08-25 Thread Martin Jambor
Hi, On Tue, Aug 25, 2015 at 12:06:13PM +0100, Alan Lawrence wrote: > This is a small refactoring/renaming patch, it just moves the call to > "completely_scalarize_record" out from completely_scalarize_var, and renames > the latter to create_total_scalarization_access. > > This is because the next

Re: [PATCH 1/5] Refactor completely_scalarize_var

2015-08-25 Thread Jeff Law
On 08/25/2015 05:06 AM, Alan Lawrence wrote: This is a small refactoring/renaming patch, it just moves the call to "completely_scalarize_record" out from completely_scalarize_var, and renames the latter to create_total_scalarization_access. This is because the next patch needs to drop the "_reco