Re: [PATCH 1/5] Common API for accessing global and on-demand ranges.

2021-05-28 Thread Jeff Law via Gcc-patches
On 5/25/2021 10:16 AM, Aldy Hernandez via Gcc-patches wrote: The interface is now an inline function for get_range_query() and an external function for get_global_range_query), as discussed. There are no magic cfun uses behind the scenes. The annoying downcast is gone. Passes can now decid

Re: [PATCH 1/5] Common API for accessing global and on-demand ranges.

2021-05-26 Thread Andrew MacLeod via Gcc-patches
On 5/25/21 12:16 PM, Aldy Hernandez wrote: The interface is now an inline function for get_range_query() and an external function for get_global_range_query), as discussed. There are no magic cfun uses behind the scenes. The annoying downcast is gone. Passes can now decide if they want to exp

Re: [PATCH 1/5] Common API for accessing global and on-demand ranges.

2021-05-25 Thread Aldy Hernandez via Gcc-patches
The interface is now an inline function for get_range_query() and an external function for get_global_range_query), as discussed. There are no magic cfun uses behind the scenes. The annoying downcast is gone. Passes can now decide if they want to export global ranges after they use a ranger.

Re: [PATCH 1/5] Common API for accessing global and on-demand ranges.

2021-05-25 Thread Richard Biener via Gcc-patches
On Tue, May 25, 2021 at 12:53 PM Aldy Hernandez wrote: > > On 5/25/21 11:46 AM, Richard Biener wrote: > > On Tue, May 25, 2021 at 11:36 AM Aldy Hernandez wrote: > >> > >> > >> > >> On 5/25/21 10:57 AM, Richard Biener wrote: > >>> On Mon, May 24, 2021 at 6:44 PM Aldy Hernandez via Gcc-patches > >>

Re: [PATCH 1/5] Common API for accessing global and on-demand ranges.

2021-05-25 Thread Aldy Hernandez via Gcc-patches
On 5/25/21 11:46 AM, Richard Biener wrote: On Tue, May 25, 2021 at 11:36 AM Aldy Hernandez wrote: On 5/25/21 10:57 AM, Richard Biener wrote: On Mon, May 24, 2021 at 6:44 PM Aldy Hernandez via Gcc-patches wrote: On 5/21/21 1:39 PM, Aldy Hernandez wrote: This patch provides a generic AP

Re: [PATCH 1/5] Common API for accessing global and on-demand ranges.

2021-05-25 Thread Richard Biener via Gcc-patches
On Tue, May 25, 2021 at 11:36 AM Aldy Hernandez wrote: > > > > On 5/25/21 10:57 AM, Richard Biener wrote: > > On Mon, May 24, 2021 at 6:44 PM Aldy Hernandez via Gcc-patches > > wrote: > >> > >> > >> > >> On 5/21/21 1:39 PM, Aldy Hernandez wrote: > >>> This patch provides a generic API for accessi

Re: [PATCH 1/5] Common API for accessing global and on-demand ranges.

2021-05-25 Thread Aldy Hernandez via Gcc-patches
On 5/25/21 10:57 AM, Richard Biener wrote: On Mon, May 24, 2021 at 6:44 PM Aldy Hernandez via Gcc-patches wrote: On 5/21/21 1:39 PM, Aldy Hernandez wrote: This patch provides a generic API for accessing global ranges. It is meant to replace get_range_info() and get_ptr_nonnull() with on

Re: [PATCH 1/5] Common API for accessing global and on-demand ranges.

2021-05-25 Thread Richard Biener via Gcc-patches
On Mon, May 24, 2021 at 6:44 PM Aldy Hernandez via Gcc-patches wrote: > > > > On 5/21/21 1:39 PM, Aldy Hernandez wrote: > > This patch provides a generic API for accessing global ranges. It is > > meant to replace get_range_info() and get_ptr_nonnull() with one > > common interface. It uses the

Re: [PATCH 1/5] Common API for accessing global and on-demand ranges.

2021-05-25 Thread Aldy Hernandez via Gcc-patches
On 5/24/21 9:13 PM, Martin Sebor wrote: On 5/21/21 5:39 AM, Aldy Hernandez via Gcc-patches wrote: +  /* Range query mechanism for functions.  The default is to pick up + global ranges.  If a pass wants on-demand ranges OTOH, it must + call enable/disable_ranger().  */ +  range_query

Re: [PATCH 1/5] Common API for accessing global and on-demand ranges.

2021-05-24 Thread Martin Sebor via Gcc-patches
On 5/21/21 5:39 AM, Aldy Hernandez via Gcc-patches wrote: This patch provides a generic API for accessing global ranges. It is meant to replace get_range_info() and get_ptr_nonnull() with one common interface. It uses the same API as the ranger (class range_query), so there will now be one API

Re: [PATCH 1/5] Common API for accessing global and on-demand ranges.

2021-05-24 Thread Aldy Hernandez via Gcc-patches
On 5/21/21 1:39 PM, Aldy Hernandez wrote: This patch provides a generic API for accessing global ranges. It is meant to replace get_range_info() and get_ptr_nonnull() with one common interface. It uses the same API as the ranger (class range_query), so there will now be one API for accessing