Re: [PATCH 1/4] unroll: Add middle-end unroll factor estimation

2021-02-28 Thread Kewen.Lin via Gcc-patches
on 2021/1/27 下午5:43, Kewen.Lin via Gcc-patches wrote: > on 2021/1/26 下午6:53, Richard Biener wrote: >> On Tue, 26 Jan 2021, Kewen.Lin wrote: >> >>> Hi Segher/Richard B./Richard S., >>> >>> Many thanks for your all helps and comments on this! >>> >>> on 2021/1/25 下午3:56, Richard Biener wrote: On

Re: [PATCH 1/4] unroll: Add middle-end unroll factor estimation

2021-01-27 Thread Kewen.Lin via Gcc-patches
on 2021/1/26 下午6:53, Richard Biener wrote: > On Tue, 26 Jan 2021, Kewen.Lin wrote: > >> Hi Segher/Richard B./Richard S., >> >> Many thanks for your all helps and comments on this! >> >> on 2021/1/25 下午3:56, Richard Biener wrote: >>> On Fri, 22 Jan 2021, Segher Boessenkool wrote: >>> On Fri, J

Re: [PATCH 1/4] unroll: Add middle-end unroll factor estimation

2021-01-26 Thread Segher Boessenkool
Hi! On Tue, Jan 26, 2021 at 11:47:53AM +0100, Richard Biener wrote: > Anyway, I think the GIMPLE -> RTL transition currently is a too > big step Much agreed. I also think that the expand pass itself needs a lot of work to bring it into this century: it does much too much work, in a circuitous wa

Re: [PATCH 1/4] unroll: Add middle-end unroll factor estimation

2021-01-26 Thread Segher Boessenkool
On Tue, Jan 26, 2021 at 04:53:25PM +0800, Kewen.Lin wrote: > on 2021/1/26 上午4:37, Segher Boessenkool wrote: > > On Mon, Jan 25, 2021 at 05:59:23PM +, Richard Sandiford wrote: > >> Richard Biener writes: > >>> On Fri, 22 Jan 2021, Segher Boessenkool wrote: > But what could have been done d

Re: [PATCH 1/4] unroll: Add middle-end unroll factor estimation

2021-01-26 Thread Richard Biener
On Tue, 26 Jan 2021, Kewen.Lin wrote: > Hi Segher/Richard B./Richard S., > > Many thanks for your all helps and comments on this! > > on 2021/1/25 下午3:56, Richard Biener wrote: > > On Fri, 22 Jan 2021, Segher Boessenkool wrote: > > > >> On Fri, Jan 22, 2021 at 02:47:06PM +0100, Richard Biener w

Re: [PATCH 1/4] unroll: Add middle-end unroll factor estimation

2021-01-26 Thread Richard Biener
On Mon, 25 Jan 2021, Richard Sandiford wrote: > Richard Biener writes: > > On Fri, 22 Jan 2021, Segher Boessenkool wrote: > > > >> On Fri, Jan 22, 2021 at 02:47:06PM +0100, Richard Biener wrote: > >> > On Thu, 21 Jan 2021, Segher Boessenkool wrote: > >> > > What is holding up this patch still? K

Re: [PATCH 1/4] unroll: Add middle-end unroll factor estimation

2021-01-26 Thread Kewen.Lin via Gcc-patches
on 2021/1/26 上午4:37, Segher Boessenkool wrote: > Hi! > > On Mon, Jan 25, 2021 at 05:59:23PM +, Richard Sandiford wrote: >> Richard Biener writes: >>> On Fri, 22 Jan 2021, Segher Boessenkool wrote: But what could have been done differently that would have helped? Of course Ke Wen co

Re: [PATCH 1/4] unroll: Add middle-end unroll factor estimation

2021-01-26 Thread Kewen.Lin via Gcc-patches
on 2021/1/26 上午1:59, Richard Sandiford via Gcc-patches wrote: > Richard Biener writes: >> On Fri, 22 Jan 2021, Segher Boessenkool wrote: >> >>> On Fri, Jan 22, 2021 at 02:47:06PM +0100, Richard Biener wrote: On Thu, 21 Jan 2021, Segher Boessenkool wrote: > What is holding up this patch st

Re: [PATCH 1/4] unroll: Add middle-end unroll factor estimation

2021-01-26 Thread Kewen.Lin via Gcc-patches
Hi Segher/Richard B./Richard S., Many thanks for your all helps and comments on this! on 2021/1/25 下午3:56, Richard Biener wrote: > On Fri, 22 Jan 2021, Segher Boessenkool wrote: > >> On Fri, Jan 22, 2021 at 02:47:06PM +0100, Richard Biener wrote: >>> On Thu, 21 Jan 2021, Segher Boessenkool wrote

Re: [PATCH 1/4] unroll: Add middle-end unroll factor estimation

2021-01-25 Thread Segher Boessenkool
Hi! On Mon, Jan 25, 2021 at 05:59:23PM +, Richard Sandiford wrote: > Richard Biener writes: > > On Fri, 22 Jan 2021, Segher Boessenkool wrote: > >> But what could have been done differently that would have helped? Of > >> course Ke Wen could have written a better patch (aka one that is more

Re: [PATCH 1/4] unroll: Add middle-end unroll factor estimation

2021-01-25 Thread Richard Sandiford via Gcc-patches
Richard Biener writes: > On Fri, 22 Jan 2021, Segher Boessenkool wrote: > >> On Fri, Jan 22, 2021 at 02:47:06PM +0100, Richard Biener wrote: >> > On Thu, 21 Jan 2021, Segher Boessenkool wrote: >> > > What is holding up this patch still? Ke Wen has pinged it every month >> > > since May, and there

Re: [PATCH 1/4] unroll: Add middle-end unroll factor estimation

2021-01-24 Thread Richard Biener
On Fri, 22 Jan 2021, Segher Boessenkool wrote: > On Fri, Jan 22, 2021 at 02:47:06PM +0100, Richard Biener wrote: > > On Thu, 21 Jan 2021, Segher Boessenkool wrote: > > > What is holding up this patch still? Ke Wen has pinged it every month > > > since May, and there has still not been a review. >

Re: [PATCH 1/4] unroll: Add middle-end unroll factor estimation

2021-01-22 Thread Segher Boessenkool
On Fri, Jan 22, 2021 at 02:47:06PM +0100, Richard Biener wrote: > On Thu, 21 Jan 2021, Segher Boessenkool wrote: > > What is holding up this patch still? Ke Wen has pinged it every month > > since May, and there has still not been a review. Richard Sandiford wrote: > FAOD (since I'm on cc:), I do

Re: [PATCH 1/4] unroll: Add middle-end unroll factor estimation

2021-01-22 Thread Richard Biener
On Thu, 21 Jan 2021, Segher Boessenkool wrote: > Hi! > > What is holding up this patch still? Ke Wen has pinged it every month > since May, and there has still not been a review. I don't like it, it feels wrong but I don't have a good suggestion that had positive feedback. Since a reviewer / a

Re: [PATCH 1/4] unroll: Add middle-end unroll factor estimation

2021-01-22 Thread Richard Sandiford via Gcc-patches
Segher Boessenkool writes: > Hi! > > What is holding up this patch still? Ke Wen has pinged it every month > since May, and there has still not been a review. FAOD (since I'm on cc:), I don't feel qualified to review this. Tree-level loop stuff isn't really my area. Thanks, Richard > > > Seghe

Re: [PATCH 1/4] unroll: Add middle-end unroll factor estimation

2021-01-21 Thread Segher Boessenkool
Hi! What is holding up this patch still? Ke Wen has pinged it every month since May, and there has still not been a review. Segher On Thu, May 28, 2020 at 08:19:59PM +0800, Kewen.Lin wrote: > > gcc/ChangeLog > > 2020-MM-DD Kewen Lin > > * cfgloop.h (struct loop): New field estimat