Re: [PATCH 1/3] PHIOPT: Add diamond bb form to factor_out_conditional_conversion

2023-05-08 Thread Richard Biener via Gcc-patches
On Mon, May 8, 2023 at 9:09 AM Andrew Pinski wrote: > > On Sun, May 7, 2023 at 11:53 PM Richard Biener via Gcc-patches > wrote: > > > > On Mon, May 8, 2023 at 8:51 AM Richard Biener > > wrote: > > > > > > On Sun, May 7, 2023 at 7:05 AM Andrew Pinski via Gcc-patches > > > wrote: > > > > > > > >

Re: [PATCH 1/3] PHIOPT: Add diamond bb form to factor_out_conditional_conversion

2023-05-08 Thread Andrew Pinski via Gcc-patches
On Sun, May 7, 2023 at 11:53 PM Richard Biener via Gcc-patches wrote: > > On Mon, May 8, 2023 at 8:51 AM Richard Biener > wrote: > > > > On Sun, May 7, 2023 at 7:05 AM Andrew Pinski via Gcc-patches > > wrote: > > > > > > So the function factor_out_conditional_conversion already supports > > > di

Re: [PATCH 1/3] PHIOPT: Add diamond bb form to factor_out_conditional_conversion

2023-05-07 Thread Richard Biener via Gcc-patches
On Mon, May 8, 2023 at 8:51 AM Richard Biener wrote: > > On Sun, May 7, 2023 at 7:05 AM Andrew Pinski via Gcc-patches > wrote: > > > > So the function factor_out_conditional_conversion already supports > > diamond shaped bb forms, just need to be called for such a thing. > > > > harden-cond-comp.

Re: [PATCH 1/3] PHIOPT: Add diamond bb form to factor_out_conditional_conversion

2023-05-07 Thread Richard Biener via Gcc-patches
On Sun, May 7, 2023 at 7:05 AM Andrew Pinski via Gcc-patches wrote: > > So the function factor_out_conditional_conversion already supports > diamond shaped bb forms, just need to be called for such a thing. > > harden-cond-comp.c needed to be changed as we would optimize out the > conversion now a