Re: [PATCH 1/3] [ARM] Add bus_width_bits to tune_params

2017-11-20 Thread Charles Baylis
On 15 September 2017 at 18:01, Kyrill Tkachov wrote: > From what I can tell Ramana and Richard preferred to encode this attribute > as > a tuning struct property rather than an inline conditional based on > arm_arch7. > I agree that if we want to use that information, it should be encoded this >

Re: [PATCH 1/3] [ARM] Add bus_width_bits to tune_params

2017-09-15 Thread Kyrill Tkachov
On 15/09/17 16:38, Charles Baylis wrote: On 13 September 2017 at 10:02, Kyrill Tkachov wrote: Hi Charles, On 12/09/17 09:34, charles.bay...@linaro.org wrote: From: Charles Baylis Add bus widths. These use the approximation that v7 and later cores have 64bit data bus width, and earlier cor

Re: [PATCH 1/3] [ARM] Add bus_width_bits to tune_params

2017-09-15 Thread Charles Baylis
On 13 September 2017 at 10:02, Kyrill Tkachov wrote: > Hi Charles, > > On 12/09/17 09:34, charles.bay...@linaro.org wrote: >> >> From: Charles Baylis >> >> Add bus widths. These use the approximation that v7 and later cores have >> 64bit data bus width, and earlier cores have 32 bit bus width, w

Re: [PATCH 1/3] [ARM] Add bus_width_bits to tune_params

2017-09-13 Thread Wilco Dijkstra
Hi Charlie, I can't see any use for adding a bus width to tune params. There are many different buses in a modern CPU, so there is no such thing as a single "bus width". What we need is to add separate costs for the different kinds of loads and stores. The timings for these depend mostly on the m

Re: [PATCH 1/3] [ARM] Add bus_width_bits to tune_params

2017-09-13 Thread Kyrill Tkachov
Hi Charles, On 12/09/17 09:34, charles.bay...@linaro.org wrote: From: Charles Baylis Add bus widths. These use the approximation that v7 and later cores have 64bit data bus width, and earlier cores have 32 bit bus width, with the exception of v7m. Given the way this field is used in patch 2