Re: [PATCH 1/2] libada/Makefile.in: Add CFLAGS_FOR_TARGET to GNATLIBCFLAGS_FOR_C

2014-08-12 Thread Arnaud Charlet
> I don't know when I last built it but it has been broken for a while and > I didn't get a chance to track it down and submit patches. OK well as I said, as long as your change doesn't break other targets, that's OK. > I have had local patches but didn't like them. Ada is just a volunteer > act

Re: [PATCH 1/2] libada/Makefile.in: Add CFLAGS_FOR_TARGET to GNATLIBCFLAGS_FOR_C

2014-08-12 Thread Joel Sherrill
On 8/12/2014 2:22 PM, Arnaud Charlet wrote: >> It was in the rts Makefile back when it was under gcc. I suspect it >> disappeared when this >> all moved to libada. Could check the history if we need to. > Well, libada has been introduced many many years ago. Are you saying you > haven't built Ada

Re: [PATCH 1/2] libada/Makefile.in: Add CFLAGS_FOR_TARGET to GNATLIBCFLAGS_FOR_C

2014-08-12 Thread Arnaud Charlet
> It was in the rts Makefile back when it was under gcc. I suspect it > disappeared when this > all moved to libada. Could check the history if we need to. Well, libada has been introduced many many years ago. Are you saying you haven't built Ada since then, or were using local patches? Arno

Re: [PATCH 1/2] libada/Makefile.in: Add CFLAGS_FOR_TARGET to GNATLIBCFLAGS_FOR_C

2014-08-12 Thread Joel Sherrill
On 8/12/2014 12:33 PM, Arnaud Charlet wrote: >> This didn't get any comments earlier. Is it OK to comment? > This one is a bit tricky so requires more thoughts. On which targets did > you test it? native CentOS and sparc-rtems4.11. I don't have access to much else except *-rtems* which is basical

Re: [PATCH 1/2] libada/Makefile.in: Add CFLAGS_FOR_TARGET to GNATLIBCFLAGS_FOR_C

2014-08-12 Thread Arnaud Charlet
> This didn't get any comments earlier. Is it OK to comment? This one is a bit tricky so requires more thoughts. On which targets did you test it? > Somewhere along the way, the Ada run-time Makefile's quit > honoring CFLAGS_FOR_TARGET. This just adds it back. > > 2014-08-12 Joel Sherrill > >