Re: [PATCH 1/2] Update iterator of next

2019-11-15 Thread Jan Hubicka
> The bug in the walker loop here IMO predated C++ conversion, but to > avoid member function freeing THIS we probably want to have: > > cgraph_edge::remove (e), > symtab_node::remove (e), > ipa_ref::remove (ref), > cgraph_node::resolve_speculation (e, target) Actually thinking of this, perhas rem

Re: [PATCH 1/2] Update iterator of next

2019-11-15 Thread Jan Hubicka
> Hi, > > On Fri, Nov 15 2019, luoxhu wrote: > > > > Sorry to break the bootstrap. This was my lack of consideration when > > splitting this small piece of code from the previous patch, the line > > should be in the first line of the second loop. Could you please add > > some comments that edge

Re: [PATCH 1/2] Update iterator of next

2019-11-15 Thread Martin Jambor
Hi, On Fri, Nov 15 2019, luoxhu wrote: > > Sorry to break the bootstrap. This was my lack of consideration when > splitting this small piece of code from the previous patch, the line > should be in the first line of the second loop. Could you please add > some comments that edge may be freed in

Re: [PATCH 1/2] Update iterator of next

2019-11-15 Thread luoxhu
On 2019/11/15 17:19, Jan Hubicka wrote: >> On Fri, Nov 15, 2019 at 9:10 AM Jan Hubicka wrote: >>> next is initialized only in the loop before, it is never updated in it's own loop. gcc/ChangeLog 2019-11-15 Xiong Hu Luo * ipa-inline.c (inl

Re: [PATCH 1/2] Update iterator of next

2019-11-15 Thread Jan Hubicka
> On Fri, Nov 15, 2019 at 10:16 AM Richard Biener > wrote: > > > > On Fri, Nov 15, 2019 at 9:10 AM Jan Hubicka wrote: > > > > > > > next is initialized only in the loop before, it is never updated > > > > in it's own loop. > > > > > > > > gcc/ChangeLog > > > > > > > > 2019-11-15 Xiong Hu L

Re: [PATCH 1/2] Update iterator of next

2019-11-15 Thread Jan Hubicka
> On Fri, Nov 15, 2019 at 9:10 AM Jan Hubicka wrote: > > > > > next is initialized only in the loop before, it is never updated > > > in it's own loop. > > > > > > gcc/ChangeLog > > > > > > 2019-11-15 Xiong Hu Luo > > > > > > * ipa-inline.c (inline_small_functions): Update iterator

Re: [PATCH 1/2] Update iterator of next

2019-11-15 Thread Richard Biener
On Fri, Nov 15, 2019 at 10:16 AM Richard Biener wrote: > > On Fri, Nov 15, 2019 at 9:10 AM Jan Hubicka wrote: > > > > > next is initialized only in the loop before, it is never updated > > > in it's own loop. > > > > > > gcc/ChangeLog > > > > > > 2019-11-15 Xiong Hu Luo > > > > > >

Re: [PATCH 1/2] Update iterator of next

2019-11-15 Thread Richard Biener
On Fri, Nov 15, 2019 at 9:10 AM Jan Hubicka wrote: > > > next is initialized only in the loop before, it is never updated > > in it's own loop. > > > > gcc/ChangeLog > > > > 2019-11-15 Xiong Hu Luo > > > > * ipa-inline.c (inline_small_functions): Update iterator of next. > > OK, > t

Re: [PATCH 1/2] Update iterator of next

2019-11-15 Thread Jan Hubicka
> next is initialized only in the loop before, it is never updated > in it's own loop. > > gcc/ChangeLog > > 2019-11-15 Xiong Hu Luo > > * ipa-inline.c (inline_small_functions): Update iterator of next. OK, thanks! Honza > --- > gcc/ipa-inline.c | 15 +-- > 1 file ch