Re: [PATCH 1/2] Avoid random stmt order result in pass_waccess::use_after_inval_p

2023-03-15 Thread Jakub Jelinek via Gcc-patches
On Wed, Mar 15, 2023 at 01:07:56PM +, Richard Biener wrote: > The following patch was bootstrapped and tested on > x86_64-unknown-linux-gnu. It now doesn't regress anything in the > testsuite but on its own it has the chance to (by luck maybe > avoided previosuly due to the PHI compare bug) i

Re: [PATCH 1/2] Avoid random stmt order result in pass_waccess::use_after_inval_p

2023-03-15 Thread Richard Biener via Gcc-patches
On Wed, 15 Mar 2023, Richard Biener wrote: > On Wed, 15 Mar 2023, Jakub Jelinek wrote: > > > On Wed, Mar 15, 2023 at 10:48:32AM +, Richard Biener wrote: > > > use_after_inval_p uses stmt UIDs to speed up repeated dominance > > > checks within a basic-block but it fails to assign UIDs to PHIs

Re: [PATCH 1/2] Avoid random stmt order result in pass_waccess::use_after_inval_p

2023-03-15 Thread Richard Biener via Gcc-patches
On Wed, 15 Mar 2023, Jakub Jelinek wrote: > On Wed, Mar 15, 2023 at 10:48:32AM +, Richard Biener wrote: > > use_after_inval_p uses stmt UIDs to speed up repeated dominance > > checks within a basic-block but it fails to assign UIDs to PHIs > > which means compares with PHIs in the same block g

Re: [PATCH 1/2] Avoid random stmt order result in pass_waccess::use_after_inval_p

2023-03-15 Thread Jakub Jelinek via Gcc-patches
On Wed, Mar 15, 2023 at 10:48:32AM +, Richard Biener wrote: > use_after_inval_p uses stmt UIDs to speed up repeated dominance > checks within a basic-block but it fails to assign UIDs to PHIs > which means compares with PHIs in the same block get a random > result. > > The following factors re