Re: [PATCH 1/2] Add support for IVOPT

Kugan Vivekanandarajah writes: > +/* Return the preferred mem scale factor for accessing MEM_MODE > + of BASE which is optimized for SPEED. */ Maybe: /* Return the preferred index scale factor for accessing memory of mode MEM_MODE in the address space of pointer BASE. Assume that we're

Re: [PATCH 1/2] Add support for IVOPT

Hi Richard, On Fri, 17 May 2019 at 18:47, Richard Sandiford wrote: > > Kugan Vivekanandarajah writes: > > [...] > >> > +{ > >> > + struct mem_address parts = {NULL_TREE, integer_one_node, > >> > + NULL_TREE, NULL_TREE, NULL_TREE}; > >> > >> Might be better

Re: [PATCH 1/2] Add support for IVOPT

Kugan Vivekanandarajah writes: > [...] >> > +{ >> > + struct mem_address parts = {NULL_TREE, integer_one_node, >> > + NULL_TREE, NULL_TREE, NULL_TREE}; >> >> Might be better to use "= {}" and initialise the fields that matter by >> assignment. As it stands t

Re: [PATCH 1/2] Add support for IVOPT

Hi Richard, On Thu, 16 May 2019 at 21:14, Richard Biener wrote: > > On Wed, May 15, 2019 at 4:40 AM wrote: > > > > From: Kugan Vivekanandarajah > > > > gcc/ChangeLog: > > > > 2019-05-15 Kugan Vivekanandarajah > > > > PR target/88834 > > * tree-ssa-loop-ivopts.c (get_mem_type_

Re: [PATCH 1/2] Add support for IVOPT

Hi Richard, On Wed, 15 May 2019 at 16:57, Richard Sandiford wrote: > > Thanks for doing this. > > kugan.vivekanandara...@linaro.org writes: > > From: Kugan Vivekanandarajah > > > > gcc/ChangeLog: > > > > 2019-05-15 Kugan Vivekanandarajah > > > > PR target/88834 > > * tree-ssa-loop

Re: [PATCH 1/2] Add support for IVOPT

On Wed, May 15, 2019 at 4:40 AM wrote: > > From: Kugan Vivekanandarajah > > gcc/ChangeLog: > > 2019-05-15 Kugan Vivekanandarajah > > PR target/88834 > * tree-ssa-loop-ivopts.c (get_mem_type_for_internal_fn): Handle > IFN_MASK_LOAD_LANES and IFN_MASK_STORE_LANES. >

Re: [PATCH 1/2] Add support for IVOPT

Richard Sandiford writes: > kugan.vivekanandara...@linaro.org writes: >> + parts.step = wide_int_to_tree (sizetype, fact); >> + /* Addressing mode "base + index << scale". */ >> + addr = addr_for_mem_ref (&parts, as, false); >> + unsigned new_cost = address_cost (addr, mem_mod

Re: [PATCH 1/2] Add support for IVOPT

Thanks for doing this. kugan.vivekanandara...@linaro.org writes: > From: Kugan Vivekanandarajah > > gcc/ChangeLog: > > 2019-05-15 Kugan Vivekanandarajah > > PR target/88834 > * tree-ssa-loop-ivopts.c (get_mem_type_for_internal_fn): Handle > IFN_MASK_LOAD_LANES and IFN_MASK_ST