Re: [PATCH 09/10] Instrument built-in memory access function calls

2012-11-12 Thread Dodji Seketeli
Diego Novillo writes: > On 2012-11-02 16:05 , Dodji Seketeli wrote: > >> +static bool >> +maybe_instrument_builtin_call (gimple_stmt_iterator *iter) >> +{ >> + gimple call = gsi_stmt (*iter); >> + location_t loc = gimple_location (call); >> + >> + if (!is_gimple_call (call)) >> +return fal

Re: [PATCH 09/10] Instrument built-in memory access function calls

2012-11-06 Thread Diego Novillo
On 2012-11-02 16:05 , Dodji Seketeli wrote: +static bool +maybe_instrument_builtin_call (gimple_stmt_iterator *iter) +{ + gimple call = gsi_stmt (*iter); + location_t loc = gimple_location (call); + + if (!is_gimple_call (call)) +return false; Nit. Why not factor this out and change th