Re: [PATCH 06/13] Implement protection of stack variables

2012-11-02 Thread Dodji Seketeli
Konstantin Serebryany writes: > http://research.google.com/pubs/archive/37752.pdf > The horizontal drawing is given in section 3.3 and hence the redzones there > are called left/right. > The stack poisoning is only explained using an example in C. Great, thanks. This makes it easier to understa

Re: [PATCH 06/13] Implement protection of stack variables

2012-11-02 Thread Dodji Seketeli
Xinliang David Li writes: > Changing the option is part of the plan. Indeed. > Dodji, can you make the option change part of one the patches (e.g, > the first one that introduces it) -- there seems no need for a > separate patch for it. Sure thing. I have done the change on my local tree. I'

Re: [PATCH 06/13] Implement protection of stack variables

2012-11-02 Thread Dodji Seketeli
Konstantin Serebryany writes: >> [A cultural question I've kept asking myself is Why has address >> sanitizer authors called these red zones (LEFT, MIDDLE, RIGHT) >> instead of e.g, (BOTTOM, MIDDLE, TOP). Maybe they can step up and >> educate me so that I get less confused in the future. :-)

Re: [PATCH 06/13] Implement protection of stack variables

2012-11-01 Thread Xinliang David Li
Changing the option is part of the plan. Dodji, can you make the option change part of one the patches (e.g, the first one that introduces it) -- there seems no need for a separate patch for it. thanks, David On Thu, Nov 1, 2012 at 9:12 PM, Konstantin Serebryany wrote: > > > On Thu, Nov 1, 201