Re: Passes are now C++ classes (was Re: [PATCH 03/11] Handwritten part of conversion of passes to C++ classes)

2013-08-07 Thread Eric Botcazou
> The mips*-*-* targets are not building. It looks like the mips reorg > pass (pass_mips_machine_reorg2) in config/mips/mips.c was not converted > and/or was not converted correctly. Likewise for the SPARC targets, because of the same issue. David, could you take a quick look? Thanks in advanc

Re: Passes are now C++ classes (was Re: [PATCH 03/11] Handwritten part of conversion of passes to C++ classes)

2013-08-06 Thread Basile Starynkevitch
On Mon, 2013-08-05 at 17:03 -0400, David Malcolm wrote: > On Mon, 2013-07-29 at 15:41 -0600, Jeff Law wrote: > > On 07/26/2013 09:04 AM, David Malcolm wrote: > > > This patch is the hand-written part of the conversion of passes from > > > C structs to C++ classes. It does not work without the subs

Re: [Patch] Unbreak build on mips (was Re: Passes are now C++ classes (was Re: [PATCH 03/11] Handwritten part of conversion of passes to C++ classes))

2013-08-06 Thread David Malcolm
On Tue, 2013-08-06 at 19:11 +0100, Richard Sandiford wrote: > David Malcolm writes: > > commit 11d46884e8bd9802b0f528a16b3970b4076fe8a9 > > Author: David Malcolm > > Date: Tue Aug 6 13:48:59 2013 -0400 > > > > gcc/ > > * config/mips/mips.c (insert_pass_mips_machine_reorg2): Move

Re: [Patch] Unbreak build on mips (was Re: Passes are now C++ classes (was Re: [PATCH 03/11] Handwritten part of conversion of passes to C++ classes))

2013-08-06 Thread Richard Sandiford
David Malcolm writes: > commit 11d46884e8bd9802b0f528a16b3970b4076fe8a9 > Author: David Malcolm > Date: Tue Aug 6 13:48:59 2013 -0400 > > gcc/ > * config/mips/mips.c (insert_pass_mips_machine_reorg2): Move > into... > (mips_option_override): ...here, porting to new C++ API

[Patch] Unbreak build on mips (was Re: Passes are now C++ classes (was Re: [PATCH 03/11] Handwritten part of conversion of passes to C++ classes))

2013-08-06 Thread David Malcolm
On Tue, 2013-08-06 at 08:16 -0700, Steve Ellcey wrote: > On Mon, 2013-08-05 at 17:03 -0400, David Malcolm wrote: > > > Given all of the above testing I'm reasonably confident that this works. > > However this is such a large change [1] that there's a non-zero chance > > of at least one glitch - le

Re: Passes are now C++ classes (was Re: [PATCH 03/11] Handwritten part of conversion of passes to C++ classes)

2013-08-06 Thread Steve Ellcey
On Mon, 2013-08-05 at 17:03 -0400, David Malcolm wrote: > Given all of the above testing I'm reasonably confident that this works. > However this is such a large change [1] that there's a non-zero chance > of at least one glitch - let me know if you see any breakages. The mips*-*-* targets are no

Passes are now C++ classes (was Re: [PATCH 03/11] Handwritten part of conversion of passes to C++ classes)

2013-08-05 Thread David Malcolm
On Mon, 2013-07-29 at 15:41 -0600, Jeff Law wrote: > On 07/26/2013 09:04 AM, David Malcolm wrote: > > This patch is the hand-written part of the conversion of passes from > > C structs to C++ classes. It does not work without the subsequent > > autogenerated part, which is huge. > [ ... ] > With t

Re: [PATCH 3.1/11] Explicitly initialize the macro-generated pass fields (was Re: [PATCH 03/11] Handwritten part of conversion of passes to C++ classes)

2013-08-03 Thread Richard Henderson
On 08/02/2013 02:38 PM, David Malcolm wrote: > OK for trunk? (as part of patches 3-6) Ok.

Re: [PATCH 3.1/11] Explicitly initialize the macro-generated pass fields (was Re: [PATCH 03/11] Handwritten part of conversion of passes to C++ classes)

2013-08-02 Thread David Malcolm
On Thu, 2013-08-01 at 13:13 -0400, David Malcolm wrote: > On Mon, 2013-07-29 at 15:41 -0600, Jeff Law wrote: > > On 07/26/2013 09:04 AM, David Malcolm wrote: > > > This patch is the hand-written part of the conversion of passes from > > > C structs to C++ classes. It does not work without the subs

[PATCH 3.1/11] Explicitly initialize the macro-generated pass fields (was Re: [PATCH 03/11] Handwritten part of conversion of passes to C++ classes)

2013-08-01 Thread David Malcolm
On Mon, 2013-07-29 at 15:41 -0600, Jeff Law wrote: > On 07/26/2013 09:04 AM, David Malcolm wrote: > > This patch is the hand-written part of the conversion of passes from > > C structs to C++ classes. It does not work without the subsequent > > autogenerated part, which is huge. > [ ... ] > With t

Re: [PATCH 03/11] Handwritten part of conversion of passes to C++ classes

2013-07-29 Thread Jeff Law
On 07/26/2013 09:04 AM, David Malcolm wrote: This patch is the hand-written part of the conversion of passes from C structs to C++ classes. It does not work without the subsequent autogenerated part, which is huge. [ ... ] With the changes from pipeline -> pass_manager this is fine. As is the

Re: [PATCH 03/11] Handwritten part of conversion of passes to C++ classes

2013-07-29 Thread David Malcolm
On Sun, 2013-07-28 at 10:37 +0200, Basile Starynkevitch wrote: > On Fri, 2013-07-26 at 11:04 -0400, David Malcolm wrote: > > This patch is the hand-written part of the conversion of passes from > > C structs to C++ classes. It does not work without the subsequent > > autogenerated part, which is h

Re: [PATCH 03/11] Handwritten part of conversion of passes to C++ classes

2013-07-28 Thread Basile Starynkevitch
On Fri, 2013-07-26 at 11:04 -0400, David Malcolm wrote: > This patch is the hand-written part of the conversion of passes from > C structs to C++ classes. It does not work without the subsequent > autogenerated part, which is huge. > > Given that the autogenerated part of the conversion is very l