Re: [PATCH 00/17] RFC: Addding a unit testing framework to gcc

2015-06-23 Thread Mike Stump
On Jun 10, 2015, at 10:16 AM, David Malcolm wrote: > It doesn't have an output formatter for the DejaGnu format, but I guess > I could write one. The gtest standard output format is IMHO superior to > DejaGnu's since it tells you start-of-test/end-of-test on separate > lines, so you can see which

Re: [PATCH/RFC]: unittesting v2: as a plugin (was Re: [PATCH 00/17] RFC: Addding a unit testing framework to gcc)

2015-06-23 Thread Jeff Law
On 06/17/2015 01:48 PM, David Malcolm wrote: On Thu, 2015-06-11 at 00:18 +0200, Jakub Jelinek wrote: I wrote a custom formatter for the output (class deja_gnu_printer within unittests-plugin.c) which generates lines like this on stderr: PASS: ggc_test.tree_marking PASS: ggc_test.custom_struct P

Re: [PATCH 00/17] RFC: Addding a unit testing framework to gcc

2015-06-23 Thread Jeff Law
On 06/10/2015 11:16 AM, David Malcolm wrote: On Wed, 2015-06-10 at 17:34 +0200, Jakub Jelinek wrote: On Wed, Jun 10, 2015 at 11:24:41AM -0400, David Malcolm wrote: I picked the Google Test framework: http://code.google.com/p/googletest/ I must say I'm not very excited about using this, it

[PATCH/RFC]: unittesting v2: as a plugin (was Re: [PATCH 00/17] RFC: Addding a unit testing framework to gcc)

2015-06-17 Thread David Malcolm
On Thu, 2015-06-11 at 00:18 +0200, Jakub Jelinek wrote: > On Wed, Jun 10, 2015 at 01:16:20PM -0400, David Malcolm wrote: > > On Wed, 2015-06-10 at 17:34 +0200, Jakub Jelinek wrote: > > > On Wed, Jun 10, 2015 at 11:24:41AM -0400, David Malcolm wrote: > > > > I picked the Google Test framework: > > >

Re: [PATCH 00/17] RFC: Addding a unit testing framework to gcc

2015-06-11 Thread Martin Liška
On 06/10/2015 05:24 PM, David Malcolm wrote: Our current test suite is rather coarse-grained, acting at the level of running gcc subprocesses, and verifying externally-visible properties: - Did the compile succeed? - Was a particular dumpfile emitted, containing something matching some

Re: [PATCH 00/17] RFC: Addding a unit testing framework to gcc

2015-06-10 Thread Jakub Jelinek
On Wed, Jun 10, 2015 at 01:16:20PM -0400, David Malcolm wrote: > On Wed, 2015-06-10 at 17:34 +0200, Jakub Jelinek wrote: > > On Wed, Jun 10, 2015 at 11:24:41AM -0400, David Malcolm wrote: > > > I picked the Google Test framework: > > > http://code.google.com/p/googletest/ > > > > I must say I'm

Re: [PATCH 00/17] RFC: Addding a unit testing framework to gcc

2015-06-10 Thread Jakub Jelinek
On Wed, Jun 10, 2015 at 02:04:11PM -0400, David Malcolm wrote: > FWIW this goes away if I simply include gtest.h immediately after > config.h, but before system.h. Yeah, I guess including it before system.h and after config.h is fine. Jakub

Re: [PATCH 00/17] RFC: Addding a unit testing framework to gcc

2015-06-10 Thread David Malcolm
On Wed, 2015-06-10 at 17:34 +0200, Jakub Jelinek wrote: > On Wed, Jun 10, 2015 at 11:24:41AM -0400, David Malcolm wrote: (...snip...) > Also, no matter what testsuite framework is used, including any > headers before #include "config.h" line is a big no-no. The issue was that libiberty/safe-ctype

Re: [PATCH 00/17] RFC: Addding a unit testing framework to gcc

2015-06-10 Thread David Malcolm
On Wed, 2015-06-10 at 17:34 +0200, Jakub Jelinek wrote: > On Wed, Jun 10, 2015 at 11:24:41AM -0400, David Malcolm wrote: > > I picked the Google Test framework: > > http://code.google.com/p/googletest/ > > I must say I'm not very excited about using this, it won't integrate > very well with deja

Re: [PATCH 00/17] RFC: Addding a unit testing framework to gcc

2015-06-10 Thread Richard Biener
On June 10, 2015 5:34:47 PM GMT+02:00, Jakub Jelinek wrote: >On Wed, Jun 10, 2015 at 11:24:41AM -0400, David Malcolm wrote: >> I picked the Google Test framework: >> http://code.google.com/p/googletest/ > >I must say I'm not very excited about using this, it won't integrate >very well with dejag

Re: [PATCH 00/17] RFC: Addding a unit testing framework to gcc

2015-06-10 Thread Jakub Jelinek
On Wed, Jun 10, 2015 at 11:24:41AM -0400, David Malcolm wrote: > I picked the Google Test framework: > http://code.google.com/p/googletest/ I must say I'm not very excited about using this, it won't integrate very well with dejagnu, whether talking about results (will it provide some *.log/*.sum