Re: [PATCH 0/3] Power10 PCREL_OPT support (September 5th 2020)

2020-09-05 Thread Michael Meissner via Gcc-patches
I forgot to add Bill Schmidt's name to the ChangeLog entry. He helped with the initial conversion to use the DF framework. I will add his name in my copy of the patch. -- Michael Meissner, IBM IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA email: meiss...@linux.ibm.com, phone: +

Re: [PATCH 0/3] Power10 PCREL_OPT support

2020-08-24 Thread Bill Schmidt via Gcc-patches
On 8/24/20 11:01 PM, Michael Meissner wrote: On Sat, Aug 22, 2020 at 07:05:51PM -0500, Bill Schmidt wrote: What is necessary in order to allow this optimization to occur earlier is to make this hidden dependency explicit.  When the relocation is inserted, we have to change the "pld" instruction

Re: [PATCH 0/3] Power10 PCREL_OPT support

2020-08-24 Thread Michael Meissner via Gcc-patches
I forgot to mention that comparing the three tests of placement of the PCREL_OPT pass: Having the pass after sched2 generated the same number of PCREL_OPT relocations as having the pass immediately after reload. But having the pass just before sched2 resulted in some more PCREL_OPT relocations.

Re: [PATCH 0/3] Power10 PCREL_OPT support

2020-08-24 Thread Michael Meissner via Gcc-patches
On Sat, Aug 22, 2020 at 07:05:51PM -0500, Bill Schmidt wrote: > What is necessary in order to allow this optimization to occur > earlier is to make this hidden dependency explicit.  When the > relocation is inserted, we have to change the "pld" instruction to > have a specific clobber of (in this c

Re: [PATCH 0/3] Power10 PCREL_OPT support

2020-08-24 Thread Michael Meissner via Gcc-patches
On Thu, Aug 20, 2020 at 06:33:29PM -0500, Segher Boessenkool wrote: > > These patches allow the load of the address to not be physically adjacent to > > the actual load or store, which should allow for better code. > > Why is that? That is not what it does anyway? /confused It does allow that.

Re: [PATCH 0/3] Power10 PCREL_OPT support

2020-08-22 Thread Bill Schmidt via Gcc-patches
On 8/20/20 6:33 PM, Segher Boessenkool wrote: Hi! On Tue, Aug 18, 2020 at 02:31:41AM -0400, Michael Meissner wrote: In order to do this, the pass that converts the load address and load/store must occur late in the compilation cycle. That does not follow afaics. Let me see if I can help exp

Re: [PATCH 0/3] Power10 PCREL_OPT support

2020-08-20 Thread Segher Boessenkool
Hi! On Tue, Aug 18, 2020 at 02:31:41AM -0400, Michael Meissner wrote: > Currently on power10, the compiler compiles this as: > > ret_var: > pld 9,ext_variable@got@pcrel > lwa 3,0(9) > blr > > store_var: > pld 9,ext_variable@got@