Re: [PATCH (8/7)] Fix a bug in multiply-and-accumulate

2011-08-19 Thread Andrew Stubbs
On 21/07/11 14:14, Andrew Stubbs wrote: Here is the patch I plan to commit, when patch 1 is approved, and my testing is complete. Committed, unchanged. Andrew

Re: [PATCH (8/7)] Fix a bug in multiply-and-accumulate

2011-07-21 Thread Andrew Stubbs
On 18/07/11 15:46, Richard Guenther wrote: Will signedness be always the same? Usually the canonical check to use would be !useless_type_conversion_p (type, TREE_TYPE (add_rhs)). The signedness ought to be unimportant - any extend will be based on the source type, and the signedness should no

Re: [PATCH (8/7)] Fix a bug in multiply-and-accumulate

2011-07-18 Thread Richard Guenther
On Mon, Jul 18, 2011 at 3:14 PM, Andrew Stubbs wrote: > As far as I can tell, the patch series so far works great as long as the > input type of the accumulate value is the same as the output type. > Unfortunately you get an ICE otherwise doh! > > This patch should fix the problem. > > I coul