Re: [PATCH] v2: Formatted printing for dump_* in the middle-end

2018-08-26 Thread Jakub Jelinek
On Thu, Aug 02, 2018 at 01:54:07PM -0400, David Malcolm wrote: > +/* An attribute for annotating formatting printing functions that use > + the dumpfile/optinfo formatting codes. These are the pretty_printer > + format codes (see pretty-print.c), with additional codes for middle-end > + spec

Re: [PATCH] v2: Formatted printing for dump_* in the middle-end

2018-08-17 Thread David Malcolm
On Thu, 2018-08-16 at 22:08 -0600, Jeff Law wrote: > On 08/02/2018 11:54 AM, David Malcolm wrote: > > On Tue, 2018-07-31 at 19:56 +, Joseph Myers wrote: > > > On Tue, 31 Jul 2018, David Malcolm wrote: > > > > > > > I didn't exhaustively check every callsite to the changed > > > > calls; > > >

Re: [PATCH] v2: Formatted printing for dump_* in the middle-end

2018-08-16 Thread Jeff Law
On 08/02/2018 11:54 AM, David Malcolm wrote: > On Tue, 2018-07-31 at 19:56 +, Joseph Myers wrote: >> On Tue, 31 Jul 2018, David Malcolm wrote: >> >>> I didn't exhaustively check every callsite to the changed calls; >>> I'm >>> assuming that -Wformat during bootstrap has effectively checked >>>

Re: [PATCH] v2: Formatted printing for dump_* in the middle-end

2018-08-09 Thread Joseph Myers
On Thu, 2 Aug 2018, David Malcolm wrote: > (a) the c-format.c changes (Joseph?), and The c-format.c changes are OK. -- Joseph S. Myers jos...@codesourcery.com