Re: [PATCH] tsan: Add optional support for distinguishing volatiles

2020-05-20 Thread Martin Liška
On 5/20/20 4:04 PM, Marco Elver wrote: On Wed, 20 May 2020 at 15:30, Martin Liška wrote: On 4/23/20 5:42 PM, Marco Elver via Gcc-patches wrote: Hello. Not being a maintainer of libsanitizer but I can provide a feedback: Thank you for the review! Note, this is not touching libsanitizer or

Re: [PATCH] tsan: Add optional support for distinguishing volatiles

2020-05-20 Thread Marco Elver via Gcc-patches
On Wed, 20 May 2020 at 15:30, Martin Liška wrote: > > On 4/23/20 5:42 PM, Marco Elver via Gcc-patches wrote: > > Hello. > > Not being a maintainer of libsanitizer but I can provide a feedback: Thank you for the review! Note, this is not touching libsanitizer or user-space TSAN runtime, only the

Re: [PATCH] tsan: Add optional support for distinguishing volatiles

2020-05-20 Thread Martin Liška
On 4/23/20 5:42 PM, Marco Elver via Gcc-patches wrote: Hello. Not being a maintainer of libsanitizer but I can provide a feedback: Add support to optionally emit different instrumentation for accesses to volatile variables. While the default TSAN runtime likely will never require this feature,

Re: [PATCH] tsan: Add optional support for distinguishing volatiles

2020-05-19 Thread Martin Liška
On 5/18/20 1:52 PM, Dmitry Vyukov via Gcc-patches wrote: Jakub, could you please give some update. Do we just wait? That's fine, just want to understand because there are some interesting discussions in the kernel re bumping compiler requirements. Thanks Hello. We switched to stage1 and we're

Re: [PATCH] tsan: Add optional support for distinguishing volatiles

2020-05-18 Thread Dmitry Vyukov via Gcc-patches
On Wed, May 13, 2020 at 12:48 PM Marco Elver wrote: > > Hello, Jakub, > > > > On Tue, 28 Apr 2020 at 16:58, Dmitry Vyukov wrote: > > > > > > On Tue, Apr 28, 2020 at 4:55 PM Jakub Jelinek wrote: > > > > > > > > On Tue, Apr 28, 2020 at 04:48:31PM +0200, Dmitry Vyukov wrote: > > > > > FWIW this is:

Re: [PATCH] tsan: Add optional support for distinguishing volatiles

2020-05-13 Thread Marco Elver via Gcc-patches
On Wed, 6 May 2020 at 16:33, Marco Elver wrote: > > Hello, Jakub, > > On Tue, 28 Apr 2020 at 16:58, Dmitry Vyukov wrote: > > > > On Tue, Apr 28, 2020 at 4:55 PM Jakub Jelinek wrote: > > > > > > On Tue, Apr 28, 2020 at 04:48:31PM +0200, Dmitry Vyukov wrote: > > > > FWIW this is: > > > > > > > > A

Re: [PATCH] tsan: Add optional support for distinguishing volatiles

2020-05-06 Thread Marco Elver via Gcc-patches
Hello, Jakub, On Tue, 28 Apr 2020 at 16:58, Dmitry Vyukov wrote: > > On Tue, Apr 28, 2020 at 4:55 PM Jakub Jelinek wrote: > > > > On Tue, Apr 28, 2020 at 04:48:31PM +0200, Dmitry Vyukov wrote: > > > FWIW this is: > > > > > > Acked-by: Dmitry Vyukov > > > > > > We just landed a similar change to

Re: [PATCH] tsan: Add optional support for distinguishing volatiles

2020-04-28 Thread Dmitry Vyukov via Gcc-patches
On Tue, Apr 28, 2020 at 4:55 PM Jakub Jelinek wrote: > > On Tue, Apr 28, 2020 at 04:48:31PM +0200, Dmitry Vyukov wrote: > > FWIW this is: > > > > Acked-by: Dmitry Vyukov > > > > We just landed a similar change to llvm: > > https://github.com/llvm/llvm-project/commit/5a2c31116f412c3b6888be361137ef

Re: [PATCH] tsan: Add optional support for distinguishing volatiles

2020-04-28 Thread Jakub Jelinek via Gcc-patches
On Tue, Apr 28, 2020 at 04:48:31PM +0200, Dmitry Vyukov wrote: > FWIW this is: > > Acked-by: Dmitry Vyukov > > We just landed a similar change to llvm: > https://github.com/llvm/llvm-project/commit/5a2c31116f412c3b6888be361137efd705e05814 > > Do you have any objections? I don't have objections

Re: [PATCH] tsan: Add optional support for distinguishing volatiles

2020-04-28 Thread Dmitry Vyukov via Gcc-patches
On Thu, Apr 23, 2020 at 5:43 PM Marco Elver wrote: > > Add support to optionally emit different instrumentation for accesses to > volatile variables. While the default TSAN runtime likely will never > require this feature, other runtimes for different environments that > have subtly different memo