Re: [PATCH] sanitizer: do not inline no-sanitize into sanitizer fn

2020-06-16 Thread Jakub Jelinek via Gcc-patches
Hi! On Tue, Jun 09, 2020 at 09:58:11PM +0200, Martin Liška wrote: > On 6/9/20 9:42 PM, Rainer Orth wrote: > > Excess errors: > > cc1: error: '-fsanitize=address' is incompatible with > > '-fsanitize=kernel-address' > > Sorry for that, I'm going to install the following patch. These tests are UN

Re: [PATCH] sanitizer: do not inline no-sanitize into sanitizer fn

2020-06-09 Thread Martin Liška
On 6/9/20 9:42 PM, Rainer Orth wrote: Excess errors: cc1: error: '-fsanitize=address' is incompatible with '-fsanitize=kernel-address' Sorry for that, I'm going to install the following patch. Martin >From 20e0cd44f9c3e9402a0cd26a0332556391902cb6 Mon Sep 17 00:00:00 2001 From: Martin Liska D

Re: [PATCH] sanitizer: do not inline no-sanitize into sanitizer fn

2020-06-09 Thread Rainer Orth
Jakub Jelinek via Gcc-patches writes: > On Tue, Jun 09, 2020 at 02:32:36PM +0200, Martin Liška wrote: >> >From 5fe0671ad79d14d1c9d0fead1a471875a4416fac Mon Sep 17 00:00:00 2001 >> From: Martin Liska >> Date: Tue, 9 Jun 2020 13:03:55 +0200 >> Subject: [PATCH] sanitizer: do not inline no-sanitize

Re: [PATCH] sanitizer: do not inline no-sanitize into sanitizer fn

2020-06-09 Thread Jakub Jelinek via Gcc-patches
On Tue, Jun 09, 2020 at 02:32:36PM +0200, Martin Liška wrote: > >From 5fe0671ad79d14d1c9d0fead1a471875a4416fac Mon Sep 17 00:00:00 2001 > From: Martin Liska > Date: Tue, 9 Jun 2020 13:03:55 +0200 > Subject: [PATCH] sanitizer: do not inline no-sanitize into sanitizer fn > > gcc/ChangeLog: > >

Re: [PATCH] sanitizer: do not inline no-sanitize into sanitizer fn

2020-06-09 Thread Martin Liška
On 6/9/20 2:15 PM, Jakub Jelinek wrote: Sorry for not writing everything at once, but are the SANITIZER_POINTER_{COMPARE,SUBTRACT} differences unimportant? They are. I got confused that they are not part of SANITIZE_UNDEFINED or SANITIZE_UNDEFINED_NONDEFAULT. Anyway, good point! Martin >From

Re: [PATCH] sanitizer: do not inline no-sanitize into sanitizer fn

2020-06-09 Thread Jakub Jelinek via Gcc-patches
On Tue, Jun 09, 2020 at 02:09:06PM +0200, Martin Liška wrote: > - return ((sanitize_flags_p (SANITIZE_ADDRESS, caller) > -== sanitize_flags_p (SANITIZE_ADDRESS, callee)) > - && (sanitize_flags_p (SANITIZE_POINTER_COMPARE, caller) > - == sanitize_flags_p (SANITIZE_POINTER_CO

Re: [PATCH] sanitizer: do not inline no-sanitize into sanitizer fn

2020-06-09 Thread Martin Liška
On 6/9/20 2:01 PM, Jakub Jelinek wrote: On Tue, Jun 09, 2020 at 01:53:38PM +0200, Martin Liška wrote: + const sanitize_code codes[] = +{ + SANITIZE_ADDRESS, + SANITIZE_THREAD, + SANITIZE_LEAK, Why leak? I was too eager ;) That is really a link time option only, doesn't

Re: [PATCH] sanitizer: do not inline no-sanitize into sanitizer fn

2020-06-09 Thread Jakub Jelinek via Gcc-patches
On Tue, Jun 09, 2020 at 01:53:38PM +0200, Martin Liška wrote: > + const sanitize_code codes[] = > +{ > + SANITIZE_ADDRESS, > + SANITIZE_THREAD, > + SANITIZE_LEAK, Why leak? That is really a link time option only, doesn't affect code generation in any way. On the other side, d