Re: [PATCH] rs6000: Builtins test changes for BFP scalar tests

2021-12-01 Thread Segher Boessenkool
On Wed, Nov 17, 2021 at 02:58:54PM -0600, Bill Schmidt wrote: > Hi! This patch is broken out of the previous patch for all the builtins test > suite adjustments. Here we have some slight changes in error messages due to > how the internals have changed between the old and new builtins methods. >

Re: [PATCH] rs6000: Builtins test changes for BFP scalar tests

2021-12-01 Thread Segher Boessenkool
On Thu, Nov 18, 2021 at 03:59:41PM -0600, Bill Schmidt wrote: > On 11/18/21 3:32 PM, Segher Boessenkool wrote: > > On Thu, Nov 18, 2021 at 03:30:48PM -0600, Bill Schmidt wrote: > >> On 11/18/21 3:16 PM, Segher Boessenkool wrote: > >>> On Wed, Nov 17, 2021 at 05:06:05PM -0600, Bill Schmidt wrote: >

Re: [PATCH] rs6000: Builtins test changes for BFP scalar tests

2021-11-18 Thread Bill Schmidt via Gcc-patches
Hi! On 11/18/21 3:32 PM, Segher Boessenkool wrote: > On Thu, Nov 18, 2021 at 03:30:48PM -0600, Bill Schmidt wrote: >> On 11/18/21 3:16 PM, Segher Boessenkool wrote: >>> Hi! >>> >>> On Wed, Nov 17, 2021 at 05:06:05PM -0600, Bill Schmidt wrote: > I don't like that at all. The user didn't write

Re: [PATCH] rs6000: Builtins test changes for BFP scalar tests

2021-11-18 Thread Segher Boessenkool
On Thu, Nov 18, 2021 at 03:30:48PM -0600, Bill Schmidt wrote: > > On 11/18/21 3:16 PM, Segher Boessenkool wrote: > > Hi! > > > > On Wed, Nov 17, 2021 at 05:06:05PM -0600, Bill Schmidt wrote: > >>> I don't like that at all. The user didn't write the _vsx thing, and it > >>> isn't documented either

Re: [PATCH] rs6000: Builtins test changes for BFP scalar tests

2021-11-18 Thread Bill Schmidt via Gcc-patches
On 11/18/21 3:16 PM, Segher Boessenkool wrote: > Hi! > > On Wed, Nov 17, 2021 at 05:06:05PM -0600, Bill Schmidt wrote: >>> I don't like that at all. The user didn't write the _vsx thing, and it >>> isn't documented either (neither is the _vec one, but that is a separate >>> issue, specific to th

Re: [PATCH] rs6000: Builtins test changes for BFP scalar tests

2021-11-18 Thread Segher Boessenkool
On Thu, Nov 18, 2021 at 07:32:27AM -0600, Bill Schmidt wrote: > >>> error: '__builtin_vsx_scalar_extract_sig' requires the '-mcpu=power9' > >>> option and either the '-m64' or '-mpowerpc64' option > >>> note: builtin '__builtin_vec_scalar_extract_sig' requires builtin > >>> '__builtin_vsx_sca

Re: [PATCH] rs6000: Builtins test changes for BFP scalar tests

2021-11-18 Thread Segher Boessenkool
Hi! On Wed, Nov 17, 2021 at 05:06:05PM -0600, Bill Schmidt wrote: > > I don't like that at all. The user didn't write the _vsx thing, and it > > isn't documented either (neither is the _vec one, but that is a separate > > issue, specific to this builtin). > > I feel like I haven't explained this

Re: [PATCH] rs6000: Builtins test changes for BFP scalar tests

2021-11-18 Thread Bill Schmidt via Gcc-patches
Hi! On 11/17/21 5:06 PM, Bill Schmidt wrote: > On 11/17/21 3:32 PM, Segher Boessenkool wrote: >> On Wed, Nov 17, 2021 at 02:58:54PM -0600, Bill Schmidt wrote: >>> Hi! This patch is broken out of the previous patch for all the builtins >>> test >>> suite adjustments. Here we have some slight cha

Re: [PATCH] rs6000: Builtins test changes for BFP scalar tests

2021-11-17 Thread Bill Schmidt via Gcc-patches
On 11/17/21 3:32 PM, Segher Boessenkool wrote: > On Wed, Nov 17, 2021 at 02:58:54PM -0600, Bill Schmidt wrote: >> Hi! This patch is broken out of the previous patch for all the builtins test >> suite adjustments. Here we have some slight changes in error messages due to >> how the internals hav

Re: [PATCH] rs6000: Builtins test changes for BFP scalar tests

2021-11-17 Thread Segher Boessenkool
On Wed, Nov 17, 2021 at 02:58:54PM -0600, Bill Schmidt wrote: > Hi! This patch is broken out of the previous patch for all the builtins test > suite adjustments. Here we have some slight changes in error messages due to > how the internals have changed between the old and new builtins methods. >