Re: [PATCH] restore -Wstringop-overflow for checked strcpy/strcat (PR 85259)

2018-06-13 Thread Martin Sebor
On 06/13/2018 02:45 PM, Joseph Myers wrote: This patch (commit r261518) has broken the build of the glibc testsuite. I see, for example for aarch64-linux-gnu with build-many-glibcs.py: In function 'test_strncat', inlined from 'main' at tester.c:1621:3: tester.c:490:13: error: 'strncat' acces

Re: [PATCH] restore -Wstringop-overflow for checked strcpy/strcat (PR 85259)

2018-06-13 Thread Joseph Myers
This patch (commit r261518) has broken the build of the glibc testsuite. I see, for example for aarch64-linux-gnu with build-many-glibcs.py: In function 'test_strncat', inlined from 'main' at tester.c:1621:3: tester.c:490:13: error: 'strncat' accessing 18446744073709551600 or more bytes at

Re: [PATCH] restore -Wstringop-overflow for checked strcpy/strcat (PR 85259)

2018-06-12 Thread Martin Sebor
On 06/11/2018 03:25 PM, Jeff Law wrote: On 05/14/2018 04:41 PM, Martin Sebor wrote: r256683 committed to GCC 8 to avoiding duplicate instances of -Wstringop-overflow warnings on some targets has the unintended side-effect of suppressing even singleton instances of the warning in cases such as 's

Re: [PATCH] restore -Wstringop-overflow for checked strcpy/strcat (PR 85259)

2018-06-11 Thread Jeff Law
On 05/14/2018 04:41 PM, Martin Sebor wrote: > r256683 committed to GCC 8 to avoiding duplicate instances of > -Wstringop-overflow warnings on some targets has the unintended > side-effect of suppressing even singleton instances of the warning > in cases such as 'strcat (strcpy (buf, "hello "), "wor