Re: [PATCH] openmp: fix UBSAN error at gcc/fortran/openmp.c:4737

2020-08-17 Thread Tobias Burnus
On 8/17/20 11:15 AM, Martin Liška wrote: I'm suggesting one more clean up that uses static assert instead of a run-time check. I concur that compile-time checks are nicer. LGTM – it should be able catch this kind of mistakes. Tobias Thoughts? Martin 0001-opnemp-add-static-assert-for-claus

Re: [PATCH] openmp: fix UBSAN error at gcc/fortran/openmp.c:4737

2020-08-17 Thread Martin Liška
On 8/17/20 10:52 AM, Tobias Burnus wrote: LGTM & thanks! – Sorry for missing it. That happens. (I re-checked against the OMP_LIST_* enum and it seems to be only missing one.) Good. I'm suggesting one more clean up that uses static assert instead of a run-time check. Thoughts? Martin >From

Re: [PATCH] openmp: fix UBSAN error at gcc/fortran/openmp.c:4737

2020-08-17 Thread Tobias Burnus
On 8/17/20 10:41 AM, Martin Liška wrote: Since 21cfe724cbdc30612bf1ef59b26f19ada2210832 there's a new OMP_LIST_NONTEMPORAL value, but it was missing in resolve_omp_clauses static array that is defined at the function beginning: gcc/fortran/ChangeLog: * openmp.c (resolve_omp_clauses): Add N