Re: [PATCH] middle-end: Call get_constant_section with DECL not EXP.

2020-07-21 Thread Richard Biener via Gcc-patches
On Tue, Jul 21, 2020 at 3:17 PM David Edelsohn wrote: > > On Tue, Jul 21, 2020 at 4:04 AM Richard Biener > wrote: > > > > On Fri, Jul 10, 2020 at 4:54 PM David Edelsohn wrote: > > > > > > On Fri, Jul 10, 2020 at 2:55 AM Richard Biener > > > wrote: > > > > > > > > On Thu, Jul 9, 2020 at 8:29 PM

Re: [PATCH] middle-end: Call get_constant_section with DECL not EXP.

2020-07-21 Thread David Edelsohn via Gcc-patches
On Tue, Jul 21, 2020 at 4:04 AM Richard Biener wrote: > > On Fri, Jul 10, 2020 at 4:54 PM David Edelsohn wrote: > > > > On Fri, Jul 10, 2020 at 2:55 AM Richard Biener > > wrote: > > > > > > On Thu, Jul 9, 2020 at 8:29 PM David Edelsohn wrote: > > > > > > > > output_constant_def_contents() can c

Re: [PATCH] middle-end: Call get_constant_section with DECL not EXP.

2020-07-21 Thread Richard Biener via Gcc-patches
On Fri, Jul 10, 2020 at 4:54 PM David Edelsohn wrote: > > On Fri, Jul 10, 2020 at 2:55 AM Richard Biener > wrote: > > > > On Thu, Jul 9, 2020 at 8:29 PM David Edelsohn wrote: > > > > > > output_constant_def_contents() can call get_constant_section() with an > > > EXP that is a CONSTRUCTOR, which

Re: [PATCH] middle-end: Call get_constant_section with DECL not EXP.

2020-07-10 Thread David Edelsohn via Gcc-patches
On Fri, Jul 10, 2020 at 2:55 AM Richard Biener wrote: > > On Thu, Jul 9, 2020 at 8:29 PM David Edelsohn wrote: > > > > output_constant_def_contents() can call get_constant_section() with an > > EXP that is a CONSTRUCTOR, which is not a declaration. This can hit > > asserts in GCC machinery to ch

Re: [PATCH] middle-end: Call get_constant_section with DECL not EXP.

2020-07-09 Thread Richard Biener via Gcc-patches
On Thu, Jul 9, 2020 at 8:29 PM David Edelsohn wrote: > > output_constant_def_contents() can call get_constant_section() with an > EXP that is a CONSTRUCTOR, which is not a declaration. This can hit > asserts in GCC machinery to choose a named section for the initialization > data that expects the