Re: [PATCH] libstdc++: Remove extern "C" from Ryu sources

2021-05-11 Thread Jakub Jelinek via Gcc-patches
On Tue, May 11, 2021 at 06:07:19PM +0100, Jonathan Wakely via Gcc-patches wrote: > > I'm not sure if the abort call is necessary since the link step already > > fails with a multiple definition error (without the fix) even if the > > function is defined with an empty body. But since Jakub included

Re: [PATCH] libstdc++: Remove extern "C" from Ryu sources

2021-05-11 Thread Jonathan Wakely via Gcc-patches
On 11/05/21 13:04 -0400, Patrick Palka wrote: On Tue, 11 May 2021, Jonathan Wakely wrote: On 11/05/21 11:16 -0400, Patrick Palka via Libstdc++ wrote: > On Tue, 11 May 2021, Patrick Palka wrote: > > > floating_to_chars.cc includes the Ryu sources into an anonymous > > namespace as a convenient w

Re: [PATCH] libstdc++: Remove extern "C" from Ryu sources

2021-05-11 Thread Patrick Palka via Gcc-patches
On Tue, 11 May 2021, Jonathan Wakely wrote: > On 11/05/21 11:16 -0400, Patrick Palka via Libstdc++ wrote: > > On Tue, 11 May 2021, Patrick Palka wrote: > > > > > floating_to_chars.cc includes the Ryu sources into an anonymous > > > namespace as a convenient way to give all its symbols internal li

Re: [PATCH] libstdc++: Remove extern "C" from Ryu sources

2021-05-11 Thread Jonathan Wakely via Gcc-patches
On 11/05/21 11:16 -0400, Patrick Palka via Libstdc++ wrote: On Tue, 11 May 2021, Patrick Palka wrote: floating_to_chars.cc includes the Ryu sources into an anonymous namespace as a convenient way to give all its symbols internal linkage. But an entity declared extern "C" always has external lin

Re: [PATCH] libstdc++: Remove extern "C" from Ryu sources

2021-05-11 Thread Patrick Palka via Gcc-patches
On Tue, 11 May 2021, Patrick Palka wrote: > floating_to_chars.cc includes the Ryu sources into an anonymous > namespace as a convenient way to give all its symbols internal linkage. > But an entity declared extern "C" always has external linkage, even > from within an anonymous namespace, so this